refactor: isolate reliance on SchedulerAction this context
#7322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benlesh
force-pushed
the
schedulers-dont-use-this
branch
2 times, most recently
from
f030f9a
to
6eb4f85
Compare
This goes through and moves all of the reliance on the `this` context for scheduling to a single point, `executeSchedule`. It also moves common complexities to that helper function. All of this is done in preparation for creating newer, simplified schedulers
benlesh
force-pushed
the
schedulers-dont-use-this
branch
from
6eb4f85
to
855fab1
Compare
|
Under current Core team agreement, I'm merging this without additional review, as it's been up a long time and is landing in an alpha version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This goes through and moves all of the reliance on the
thiscontext for scheduling to a single point,executeSchedule. It also moves common complexities to that helper function. All of this is done in preparation for creating newer, simplified schedulers