fix(TestScheduler): remove applyMixins use #7325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some environments, the `applyMixins` function doesn't work as expected when used with modern JavaScript classes. This was causing issues when code was trying to access `this.logSubscribedFrame` and `this.logUnsubscribedFrame`.
benlesh
commented
Aug 19, 2023
|
|
||
| constructor(public messages: TestMessage[], scheduler: Scheduler) { | ||
| super(function (this: Observable<T>, subscriber: Subscriber<any>) { |
There was a problem hiding this comment.
Moved this super argument out to just be declared as a method. It's just less complicated.
benlesh
commented
Aug 19, 2023
| logSubscribedFrame: () => number; | ||
| // @ts-ignore: Property has no initializer and is not definitely assigned | ||
| logUnsubscribedFrame: (index: number) => void; | ||
| logSubscribedFrame = logSubscribedFrame; |
There was a problem hiding this comment.
Instead of mixins I'm just adding the methods as function properties on the classes.
benlesh
commented
Aug 19, 2023
| constructor(public messages: TestMessage[], scheduler: Scheduler) { | ||
| super(function (this: Observable<T>, subscriber: Subscriber<any>) { | ||
| const observable: ColdObservable<T> = this as any; | ||
| const index = observable.logSubscribedFrame(); |
There was a problem hiding this comment.
In particular, in some environments with CJS and ES2022, applyMixins was not adding the mixing properties to the prototype, and we were getting errors here.
cartant
approved these changes
Aug 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some environments, the
applyMixinsfunction doesn't work as expected when used with modern JavaScript classes. This was causing issues when code was trying to accessthis.logSubscribedFrameandthis.logUnsubscribedFrame.This didn't appear until we switched over to ES2022 in CJS exports, and it doesn't appear to be an issue in all runtimes. In any case, simplifying the code solved the issue. Tested against some live tests in another repo, I don't have a solid way to duplicate it here. It's sort of a fluke/one-off.