docs: fix docs-lint and docs-test command
#7364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmair
commented
Oct 27, 2023
apps/rxjs.dev/tools/transforms/angular-api-package/processors/checkOperator.js
Show resolved
Hide resolved
tmair
force-pushed
the
fix-doc-lint-and-doc-tests
branch
from
c4fc7ed
to
9706b3c
Compare
tmair
changed the title
docs-lint and docs-test commanddocs-lint and docs-test command
jakovljevic-mladen
approved these changes
Nov 8, 2023
There was a problem hiding this comment.
LGTM. Thank you @tmair.
I have one question in code, a fix (if needed) can be done in one of the next PRs.
Also, what about "lint" script from docs package.json. Can that one be fixed?
| }, | ||
| "plugins": [ | ||
| "@typescript-eslint", | ||
| // "@angular-eslint", |
There was a problem hiding this comment.
Do we have to keep the comment here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR fixes the
docs-lintanddocs-testcommand in the documentation application.The commands did not work and where throwing errors. In the process I also updated some of the tooling around linting and testing.
Related issue (if exists): None