Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect setup causes test runner stops on browser #2261

Closed
kwonoj opened this issue Jan 6, 2017 · 1 comment
Closed

Fix incorrect setup causes test runner stops on browser #2261

kwonoj opened this issue Jan 6, 2017 · 1 comment
Labels
feature PRs and issues for features help wanted Issues we wouldn't mind assistance with.

Comments

@kwonoj
Copy link
Member

kwonoj commented Jan 6, 2017

RxJS version:
master

Code to reproduce:
Run browser test

Additional information:
It seems some of test cases are having incorrect fixture setup. I can't even tell what is incorrect at this moment - it could be test case was composed incorrectly, or browser test setup might wrong. It creates intermittent test failure on browsers such as causing

  • test completes too early without executing all suite
  • some test causes test runner hangs without timeout, infinitely stays there

below screenshot illustrates first cases I could see, only 1/10 of tests are executed but marked as 100%.

image

Note this is very intermittent issue and sometimes it occurs quite easily but sometimes never occurs. to improve stability of tests, this need to be addressed and fixed.

Q: What's the difference between #1660?
: #1660 is more about issue of connection to browser testing itself, which cannot connect or either disconnect quite frequently prevents test run reliably. I have tested browserStack and it indeed works more reliably, but due to issue in our test cases it now 'reliably fails' on several browsers.

@kwonoj kwonoj added help wanted Issues we wouldn't mind assistance with. feature PRs and issues for features labels Jan 6, 2017
@kwonoj kwonoj changed the title Fix tests incorrectly setup causes test runner stops Fix incorrect setup causes test runner stops Jan 6, 2017
@kwonoj kwonoj changed the title Fix incorrect setup causes test runner stops Fix incorrect setup causes test runner stops on browser Jan 6, 2017
@lock
Copy link

lock bot commented Jun 6, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature PRs and issues for features help wanted Issues we wouldn't mind assistance with.
Projects
None yet
Development

No branches or pull requests

1 participant