Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Static pipe not able to return generic type #4110

Closed
dkosasih opened this issue Sep 7, 2018 · 0 comments
Closed

Static pipe not able to return generic type #4110

dkosasih opened this issue Sep 7, 2018 · 0 comments
Labels
help wanted Issues we wouldn't mind assistance with. TS Issues and PRs related purely to TypeScript issues

Comments

@dkosasih
Copy link
Contributor

dkosasih commented Sep 7, 2018

Bug Report

Current Behavior
Using static pipe to compose operators will lose the return type.

Reproduction

const pipes = pipe(debounceTime(500), delay(100));
const obs = timer(0, 1000).pipe(take(5));
obs.pipe(pipes).subscribe((res)=> console.log(res)); // Typing for res is lost

Expected behavior
Should be able to detect number

Environment

  • RxJS version: 6.3.2
@kwonoj kwonoj added help wanted Issues we wouldn't mind assistance with. TS Issues and PRs related purely to TypeScript issues labels Sep 7, 2018
dkosasih added a commit to dkosasih/rxjs that referenced this issue Sep 10, 2018
@dkosasih
fix(pipe): change static pipe overload to reflect source observable t…
6f8ffac 
…ype(ReactiveX#4110)
dkosasih added a commit to dkosasih/rxjs that referenced this issue Sep 10, 2018
@dkosasih
fix(pipe): change static pipe overload to reflect source observable t…
484bba4 
…ype(ReactiveX#4110)
dkosasih added a commit to dkosasih/rxjs that referenced this issue Sep 10, 2018
@dkosasih
fix(pipe): change static pipe overload to reflect source observable t…
b73d4e8 
…ype(ReactiveX#4110)
@dkosasih dkosasih mentioned this issue Sep 10, 2018
Merged
dkosasih added a commit to dkosasih/rxjs that referenced this issue Sep 11, 2018
@dkosasih
fix(pipe): static pipe should return generic functions when possible(R…
ca25f9c 
…eactiveX#4110)
dkosasih added a commit to dkosasih/rxjs that referenced this issue Sep 11, 2018
@dkosasih
fix(pipe): static pipe should return generic functions when possible(R…
4628016 
…eactiveX#4110)
benlesh pushed a commit that referenced this issue Sep 13, 2018
@dkosasih @benlesh
fix(pipe): static pipe should return generic functions when possible(#…
cea7196 
…4110) (#4129)
@cartant cartant closed this as completed Oct 22, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Nov 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
help wanted Issues we wouldn't mind assistance with. TS Issues and PRs related purely to TypeScript issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kwonoj @cartant @dkosasih