Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs]: Operator distinctUntilKeyChanged has wrong description. #4663

Open
1 of 5 tasks
BioPhoton opened this issue Mar 25, 2019 · 2 comments
Open
1 of 5 tasks

[docs]: Operator distinctUntilKeyChanged has wrong description. #4663

BioPhoton opened this issue Mar 25, 2019 · 2 comments
Labels
docs Issues and PRs related to documentation

Comments

@BioPhoton
Copy link
Contributor

Please check those that apply

  • typo
  • documentation doesn't exist
  • documentation needs clarification
  • error(s) in example
  • needs example

Description Of The Issue

The description of distinctUntilKeyChanged is a exact copy of distinctUntilChanged.
We might want to insert a real description.
@niklas-wortmann niklas-wortmann added the docs Issues and PRs related to documentation label Mar 28, 2019
@Daschyppoo
Copy link
Contributor

I'll work on it.

@Daschyppoo Daschyppoo mentioned this issue Apr 4, 2019
Merged
benlesh pushed a commit that referenced this issue Apr 23, 2019
@Daschyppoo @benlesh
docs(operator): Fitting description of distinctUntilChanged and disti…
ae04794 
…nctUntilKeyChanged (#4663) (#4686)

* docs(operator): add missing marble diagramms

* docs(operator): add fitting description and diagramm to distinctUntilKeyChanged

* docs(operator): add marbel diagramm to distinctUntilChanged

* Revert "docs(operator): add marbel diagramm to distinctUntilChanged"

This reverts commit 6bf3aae.

* Revert "docs(operator): add fitting description and diagramm to distinctUntilKeyChanged"

This reverts commit 98c23b5.

* Revert "docs(operator): add missing marble diagramms"

This reverts commit b61acad.

* docs(operator): add missing marble diagramms

* docs(operator): add fitting description and diagramm

* docs(operator): add informal and diagramm

* docs(operator): deleted duplicated line
BioPhoton pushed a commit to BioPhoton/rxjs that referenced this issue May 15, 2019
@Daschyppoo @BioPhoton
docs(operator): Fitting description of distinctUntilChanged and disti…
87fa735 
…nctUntilKeyChanged (ReactiveX#4663) (ReactiveX#4686)

* docs(operator): add missing marble diagramms

* docs(operator): add fitting description and diagramm to distinctUntilKeyChanged

* docs(operator): add marbel diagramm to distinctUntilChanged

* Revert "docs(operator): add marbel diagramm to distinctUntilChanged"

This reverts commit 6bf3aae.

* Revert "docs(operator): add fitting description and diagramm to distinctUntilKeyChanged"

This reverts commit 98c23b5.

* Revert "docs(operator): add missing marble diagramms"

This reverts commit b61acad.

* docs(operator): add missing marble diagramms

* docs(operator): add fitting description and diagramm

* docs(operator): add informal and diagramm

* docs(operator): deleted duplicated line
@Akxe
Copy link

Akxe commented Aug 27, 2019

@Daschyppoo Hi, I would love to have a mention that to emit the next value it requires false to be returned as it is the opposite of filter operator. It might not be confusing to a native English speaker, but I do always have to check against my previous uses of it to be sure. Thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs Issues and PRs related to documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Akxe @niklas-wortmann @BioPhoton @Daschyppoo