Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

windowWhen should NOT be accepting completions as notification signals! #6876

Closed
benlesh opened this issue Mar 9, 2022 · 0 comments · Fixed by #7152
Closed

windowWhen should NOT be accepting completions as notification signals! #6876

benlesh opened this issue Mar 9, 2022 · 0 comments · Fixed by #7152
Labels
8.x Issues and PRs for version 8.x bug Confirmed bug

Comments

@benlesh
Copy link
Member

benlesh commented Mar 9, 2022

See tests linked here:

#6627 (comment)
@benlesh benlesh added bug Confirmed bug 7.x Issues and PRs for version 6.x 8.x Issues and PRs for version 8.x labels Mar 9, 2022
jakovljevic-mladen added a commit to jakovljevic-mladen/rxjs that referenced this issue Sep 1, 2022
@jakovljevic-mladen
fix(windowWhen): don't signal on complete
26ad3c4 
Closes ReactiveX#6876
jakovljevic-mladen added a commit to jakovljevic-mladen/rxjs that referenced this issue Sep 1, 2022
@jakovljevic-mladen
fix(windowWhen): don't signal on complete
bc80ff2 
Closes ReactiveX#6876
@jakovljevic-mladen jakovljevic-mladen mentioned this issue Sep 1, 2022
Closed
@jakovljevic-mladen jakovljevic-mladen mentioned this issue Jan 19, 2023
Merged
benlesh pushed a commit that referenced this issue Jan 20, 2023
@jakovljevic-mladen @benlesh
fix(windowWhen): don't signal on complete
67992c4 
Closes #6876
@jakovljevic-mladen jakovljevic-mladen removed the 7.x Issues and PRs for version 6.x label Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
8.x Issues and PRs for version 8.x bug Confirmed bug
Projects
None yet
Milestone
No milestone
2 participants
@benlesh @jakovljevic-mladen