Non-strict array_search causes issues in CompositeDisposable (and likely other places)

[mbonneau]

There is non-strict array searching in side the CompositeDisposable that cause unexpected/incorrect results in some situations:

Reproducing code:

<?php

use React\EventLoop\Factory;
use Rx\Observable;
use Rx\Observer\CallbackObserver;
use Rx\Testing\TestScheduler;

require_once __DIR__ . '/vendor/autoload.php';

$loop = Factory::create();

$scheduler = new TestScheduler();

$o = Observable::interval(500)
    ->merge(Observable::range(1,3))
    ->take(5)
    ->subscribe(new CallbackObserver(function ($x) {
        echo "Next: $x\n";
    }, function (Exception $exception) {
        echo "Err\n";
    }, function () {
        echo "Complete\n";
    }), $scheduler);

$scheduler->start();

Expected output:

Next: 1
Next: 2
Next: 3
Next: 0
Next: 1
Complete

Actual output:

Next: 1
Next: 2
Next: 3

This is caused by CompositeDisposable finding the incorrect Disposable here:

RxPHP/lib/Rx/Disposable/CompositeDisposable.php

Line 48 in 7c7d858

$key = array_search($disposable, $this->disposables);

This is can be corrected by enforcing strict comparison (passing true as the third argument to array_search)

PR on the way.