Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use relative imports for all imports #72

Closed
guillermooo opened this issue Jan 10, 2016 · 3 comments
Closed

use relative imports for all imports #72

guillermooo opened this issue Jan 10, 2016 · 3 comments
Labels

Comments

@guillermooo
Copy link
Contributor

Currently absolute imports are used. This prevents the rxpy package to be easily included in other packages, when a package manager/installer isn't available (for example, a Python-extensible app that imposes non-standard requirements). By using relative imports, it'd be easy to just drop the rxpy package in a larger package and be able to import it.

IIRC, relative imports are available since py2.5 (?) so this shouldn't affect compat?

@dbrattli
Copy link
Collaborator

According to PEP8 absolute imports are recommended ... but explicit relative imports are an acceptable alternative to absolute imports. I don't have any strong feelings about this issue, so you're welcome to make a pull request.

@guillermooo
Copy link
Contributor Author

There will be imports like ...xxx and maybe even ....xxx. Not sure if that's acceptable.

@lock
Copy link

lock bot commented Jan 24, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants