Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

تغییر فونت به فونت متن باز «ساحل» برای بهبود خوانایی متن #40

Merged
merged 5 commits into from Apr 7, 2019
Merged

تغییر فونت به فونت متن باز «ساحل» برای بهبود خوانایی متن #40

merged 5 commits into from Apr 7, 2019

Conversation

mohsenkhanpour
Copy link
Contributor

@mohsenkhanpour mohsenkhanpour commented Mar 25, 2019 •
edited

image
image
image

@mohsenkhanpour mohsenkhanpour mentioned this pull request Mar 25, 2019
Closed
87 tasks
sorousht
sorousht reviewed Mar 26, 2019
View reviewed changes
Copy link
Collaborator

@sorousht sorousht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

سلام @mohsenkhanpour عزیز

پیشنهاد بسیار خوبیه. اما بنظرم پیاده‌سازیش درست نیست. انتظار نمی‌رود که توی فایل reset.css فونت دلخواه تعریف بشه و به عنوان پیش‌فرض تنظیم شود. چیزی که به ذهن من می‌رسد این است که font-face در یک فایل css جدا مثلا به نام font.css تعریف شود و در فایل src/theme.js فونت دلخواه ساحل تعریف شود و در src/components/Layout/Layout.js اعمال شود. نظر شما چیه؟

@mohsenkhanpour
Copy link
Contributor Author

mohsenkhanpour commented Mar 26, 2019 •
edited

@sorousht Check (e4e64f1) out.
I defined the font in font.css and imported it via gatsby-browser.js.
Less intrusive than putting in it reset.css and easier to edit than applying it in JSX.
What do you think?

sorousht
sorousht approved these changes Mar 26, 2019
View reviewed changes
Copy link
Collaborator

@sorousht sorousht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mohsenkhanpour It seems fine right now.
If we define a custom font family in src/theme.js, we make it more extensible for introducing multiple fonts in the possible future. Additionally, a custom font is a part of theming and it is expcted to be introduced there.

@sorousht sorousht merged commit 037e8c5 into reactjs:fa Apr 7, 2019
@mohsenkhanpour mohsenkhanpour deleted the fa-components-and-props branch June 25, 2019 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sorousht sorousht sorousht approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mohsenkhanpour @sorousht