Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thinking in React : 3 paragraph translation done #173

Open
wants to merge 31 commits into
base: main
Choose a base branch
from

Conversation

kumard3
Copy link

@kumard3 kumard3 commented Jan 8, 2022

No description provided.

Copy link
Member

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR.

I have added review till line 41.

Lets get these fixed, then we can continue with further review.
For our review process you can refer this #23

beta/next-env.d.ts Outdated Show resolved Hide resolved
beta/src/pages/learn/thinking-in-react.md Outdated Show resolved Hide resolved
beta/src/pages/learn/thinking-in-react.md Outdated Show resolved Hide resolved
beta/src/pages/learn/thinking-in-react.md Outdated Show resolved Hide resolved
beta/src/pages/learn/thinking-in-react.md Outdated Show resolved Hide resolved
beta/src/pages/learn/thinking-in-react.md Outdated Show resolved Hide resolved
beta/src/pages/learn/thinking-in-react.md Outdated Show resolved Hide resolved
beta/src/pages/learn/thinking-in-react.md Outdated Show resolved Hide resolved
beta/src/pages/learn/thinking-in-react.md Outdated Show resolved Hide resolved
beta/src/pages/learn/thinking-in-react.md Outdated Show resolved Hide resolved
@arshadkazmi42
Copy link
Member

Hi @kumard3

can you make the changes which I have suggested, once those are done. please leave a comment here. So I can reivew and continue further review of the file.

@kumard3
Copy link
Author

kumard3 commented Jan 9, 2022

Hi @kumard3

can you make the changes which I have suggested, once those are done. please leave a comment here. So I can reivew and continue further review of the file.

i think i have made all the requested changes

@arshadkazmi42
Copy link
Member

@kumard3 There are few missed and in few I had done one typo. Can you update those. Post that with can continue with review.

@kumard3
Copy link
Author

kumard3 commented Jan 14, 2022

@kumard3 There are few missed and in few I had done one typo. Can you update those. Post that with can continue with review.

i have completed the translation of this page .

@arshadkazmi42
Copy link
Member

@kumard3 You have missed following comments, can you get these fixed

#173 (comment)

#173 (comment)

#173 (comment)

Copy link
Member

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added 3 more comments till line 79.

@kumard3 Most of the translation seems wrong, I have to change complete sentences in review.

Can you revisit the doc from line 80 once and cross check with english version and fix the obvious once? Atleast the sentences itself, most of the hindi version of sentences are not making sense.

beta/src/pages/learn/thinking-in-react.md Outdated Show resolved Hide resolved
beta/src/pages/learn/thinking-in-react.md Outdated Show resolved Hide resolved
beta/src/pages/learn/thinking-in-react.md Outdated Show resolved Hide resolved
i am sorry for the late
@kumard3
Copy link
Author

kumard3 commented Jan 23, 2022

Added 3 more comments till line 79.

@kumard3 Most of the translation seems wrong, I have to change complete sentences in review.

Can you revisit the doc from line 80 once and cross check with english version and fix the obvious once? Atleast the sentences itself, most of the hindi version of sentences are not making sense.

i am having a confusion for top down what should i write ऊपर नीचे or टॉप डाउन
and for compute what should i use कम्प्यूट or गणना करना

@arshadkazmi42
Copy link
Member

Added 3 more comments till line 79.
@kumard3 Most of the translation seems wrong, I have to change complete sentences in review.
Can you revisit the doc from line 80 once and cross check with english version and fix the obvious once? Atleast the sentences itself, most of the hindi version of sentences are not making sense.

i am having a confusion for top down what should i write ऊपर नीचे or टॉप डाउन and for compute what should i use कम्प्यूट or गणना करना

I am adding some more comments, you can make changes post that.

Copy link
Member

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added comments till line 197.

Can you fix those comments and revisit the rest of the doc

beta/src/pages/learn/thinking-in-react.md Outdated Show resolved Hide resolved
beta/src/pages/learn/thinking-in-react.md Outdated Show resolved Hide resolved
beta/src/pages/learn/thinking-in-react.md Outdated Show resolved Hide resolved
beta/src/pages/learn/thinking-in-react.md Outdated Show resolved Hide resolved
beta/src/pages/learn/thinking-in-react.md Outdated Show resolved Hide resolved
@arshadkazmi42
Copy link
Member

@kumard3 Please take a pull of your branch, I have made some fixes in the code

Copy link
Member

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added more reviews till line 215


</Gotcha>

## Step 3: Find the minimal but complete representation of UI state {/*step-3-find-the-minimal-but-complete-representation-of-ui-state*/}
## Step 3: UI state का न्यूनतम लेकिन पूर्ण प्रतिनिधित्व खोजें {/*step-3-find-the-minimal-but-complete-representation-of-ui-state*/}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

प्रतिनिधित्व => रिप्रजेंटेशन


To make the UI interactive, you need to let users change your underlying data model. You will use *state* for this.
UI को इंटरैक्टिव बनाने के लिए, आपको उपयोगकर्ताओं को अपने अंतर्निहित डेटा मॉडल को बदलने की आवश्यकता है। आप इसके लिए *state* का उपयोग करेंगे।
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

उपयोगकर्ताओं => यूज़र्स


To make the UI interactive, you need to let users change your underlying data model. You will use *state* for this.
UI को इंटरैक्टिव बनाने के लिए, आपको उपयोगकर्ताओं को अपने अंतर्निहित डेटा मॉडल को बदलने की आवश्यकता है। आप इसके लिए *state* का उपयोग करेंगे।
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

अंतर्निहित => अंडरलाइंग


After building your components, you'll have a library of reusable components that render your data model. Because this is a static app, the components will only return JSX. The component at the top of the hierarchy (`FilterableProductTable`) will take your data model as a prop. This is called _one-way data flow_ because the data flows down from the top-level component to the ones at the bottom of the tree.
अपने कौम्पोनॅन्ट के निर्माण के बाद, आपके पास रीयूज़एबल कौम्पोनॅन्ट की एक लाइब्रेरी होगी जो आपके डेटा मॉडल को रेंडर करेगी। चूंकि यह एक स्टैटिक ऐप है, कौम्पोनॅन्ट केवल JSX रिटर्न करेंगे। हायरार्की में सबसे ऊपर वाले कौम्पोनॅन्ट (`FilterableProductTable`) आपके डाटा मॉडल को prop की तरह लेगा। इसे *वन-वे डेटा फ्लो* कहा जाता है क्योंकि डाटा टॉप-लेवल के कौम्पोनॅन्ट से ट्री के सबसे निचे वाले कौम्पोनॅन्ट तक फ्लो करता है।
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

डाटा => डेटा


Think of state as the minimal set of changing data that your app needs to remember. The most important principle for structuring state is to keep it [DRY (Don't Repeat Yourself](https://en.wikipedia.org/wiki/Don%27t_repeat_yourself)). Figure out the absolute minimal representation of the state your application needs and compute everything else on-demand. For example, if you're building a shopping list, you can store the items as an array in state. If you want to also display the number of items in the list, don't store the number of items as another state value--instead, read the length of your array.
state के बारे में सोचें कि आपके ऐप को याद रखने वाले डेटा के न्यूनतम सेट के रूप में सोचें। state की संरचना के लिए सबसे महत्वपूर्ण सिद्धांत इसे रखना है[DRY (Don't Repeat Yourself](https://en.wikipedia.org/wiki/Don%27t_repeat_yourself)). अपने आवेदन की जरूरतों के पूर्ण न्यूनतम प्रतिनिधित्व को समझें और मांग पर बाकी सबकुछ की गणना करें। उदाहरण के लिए, यदि आप खरीदारी सूची बना रहे हैं, तो आप वस्तुओं को state में एक सरणी के रूप में स्टोर कर सकते हैं। यदि आप सूची में वस्तुओं की संख्या भी प्रदर्शित करना चाहते हैं, तो वस्तुओं की संख्या को किसी अन्य state मूल्य के रूप में संग्रहीत न करें - इसके बजाय, अपनी सरणी की लंबाई पढ़ें।
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revisit this line. Few things does not makes sense.


Now think of all of the pieces of data in this example application:
अब इस उदाहरण में डेटा के सभी टुकड़ों के बारे में सोचें आवेदन:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

अब इस उदाहरण में डेटा के सभी टुकड़ों के बारे में सोचें आवेदन: => अब इस उदाहरण एप्लीकेशन में डेटा के सभी टुकड़ों के बारे में सोचें:

@arshadkazmi42
Copy link
Member

Hi @kumard3
Any updates?

Let me know if you need any help

@kumard3
Copy link
Author

kumard3 commented Jun 27, 2022

Hi @kumard3 Any updates?

Let me know if you need any help

I am really sorry, will be completing it by next Sunday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1st Review First phase of review beta
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants