Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translated Writing Markup with JSX Page #198

Merged
merged 14 commits into from May 10, 2022
Merged

Conversation

Anku5hk
Copy link
Contributor

@Anku5hk Anku5hk commented Mar 15, 2022

Added Hindi Translation for Writing Markup with JSX page.

Copy link
Member

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking this up.

I have added review till line 30.

Lets get these fixed, then we can continue further with the review.

Before starting on the fixes, I will suggest to read about our review process here #23

beta/src/pages/learn/writing-markup-with-jsx.md Outdated Show resolved Hide resolved
beta/src/pages/learn/writing-markup-with-jsx.md Outdated Show resolved Hide resolved
beta/src/pages/learn/writing-markup-with-jsx.md Outdated Show resolved Hide resolved
beta/src/pages/learn/writing-markup-with-jsx.md Outdated Show resolved Hide resolved
beta/src/pages/learn/writing-markup-with-jsx.md Outdated Show resolved Hide resolved
beta/src/pages/learn/writing-markup-with-jsx.md Outdated Show resolved Hide resolved
beta/src/pages/learn/writing-markup-with-jsx.md Outdated Show resolved Hide resolved
beta/src/pages/learn/writing-markup-with-jsx.md Outdated Show resolved Hide resolved
beta/src/pages/learn/writing-markup-with-jsx.md Outdated Show resolved Hide resolved
beta/src/pages/learn/writing-markup-with-jsx.md Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Mar 18, 2022

Size Changes

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

One Page Changed Size

The following page changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/learn/writing-markup-with-jsx 59.25 KB (-5 B) 154.47 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@Anku5hk
Copy link
Contributor Author

Anku5hk commented Mar 24, 2022

@arshadkazmi42 I have updated the changes, let me know if there's something else.

Copy link
Member

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work with the fixes.

I have added review till line 124.

Lets get these fixed and then we can continue further with the review

beta/src/pages/learn/writing-markup-with-jsx.md Outdated Show resolved Hide resolved
beta/src/pages/learn/writing-markup-with-jsx.md Outdated Show resolved Hide resolved
beta/src/pages/learn/writing-markup-with-jsx.md Outdated Show resolved Hide resolved
beta/src/pages/learn/writing-markup-with-jsx.md Outdated Show resolved Hide resolved
beta/src/pages/learn/writing-markup-with-jsx.md Outdated Show resolved Hide resolved
beta/src/pages/learn/writing-markup-with-jsx.md Outdated Show resolved Hide resolved
beta/src/pages/learn/writing-markup-with-jsx.md Outdated Show resolved Hide resolved
beta/src/pages/learn/writing-markup-with-jsx.md Outdated Show resolved Hide resolved
beta/src/pages/learn/writing-markup-with-jsx.md Outdated Show resolved Hide resolved
beta/src/pages/learn/writing-markup-with-jsx.md Outdated Show resolved Hide resolved
@arshadkazmi42
Copy link
Member

@Anku5hk You have missed few of the comments. Can you work on those?

@Anku5hk
Copy link
Contributor Author

Anku5hk commented Apr 5, 2022

@Anku5hk You have missed few of the comments. Can you work on those?

Okay I have updated the changes.

Copy link
Member

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great going.

I have added more review till line 219.

Lets get these closed then we can continue with further review.

beta/src/pages/learn/writing-markup-with-jsx.md Outdated Show resolved Hide resolved
beta/src/pages/learn/writing-markup-with-jsx.md Outdated Show resolved Hide resolved
beta/src/pages/learn/writing-markup-with-jsx.md Outdated Show resolved Hide resolved
beta/src/pages/learn/writing-markup-with-jsx.md Outdated Show resolved Hide resolved
beta/src/pages/learn/writing-markup-with-jsx.md Outdated Show resolved Hide resolved
beta/src/pages/learn/writing-markup-with-jsx.md Outdated Show resolved Hide resolved
beta/src/pages/learn/writing-markup-with-jsx.md Outdated Show resolved Hide resolved
beta/src/pages/learn/writing-markup-with-jsx.md Outdated Show resolved Hide resolved
beta/src/pages/learn/writing-markup-with-jsx.md Outdated Show resolved Hide resolved
beta/src/pages/learn/writing-markup-with-jsx.md Outdated Show resolved Hide resolved
Copy link
Member

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work.

I have added few more comments, Once these are fixed, we can get this merged.

beta/src/pages/learn/writing-markup-with-jsx.md Outdated Show resolved Hide resolved
beta/src/pages/learn/writing-markup-with-jsx.md Outdated Show resolved Hide resolved
beta/src/pages/learn/writing-markup-with-jsx.md Outdated Show resolved Hide resolved
beta/src/pages/learn/writing-markup-with-jsx.md Outdated Show resolved Hide resolved
beta/src/pages/learn/writing-markup-with-jsx.md Outdated Show resolved Hide resolved
@Anku5hk
Copy link
Contributor Author

Anku5hk commented May 10, 2022

@arshadkazmi42 I have updated the text, let me know if there's something else.

Copy link
Member

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 🚀

Thank you for working on this.

Lets get this merged 🎉

@arshadkazmi42 arshadkazmi42 merged commit 49dda3c into reactjs:main May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1st Review First phase of review beta
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants