Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sharing State Between Components #381

Closed
Tracked by #330
zainfathoni opened this issue Apr 28, 2023 · 3 comments · Fixed by #370
Closed
Tracked by #330

Sharing State Between Components #381

zainfathoni opened this issue Apr 28, 2023 · 3 comments · Fixed by #370

Comments

@zainfathoni
Copy link
Collaborator

zainfathoni commented Apr 28, 2023

Page: https://id.react.dev/learn/sharing-state-between-components

Assignee: @yaffalhakim1

@zainfathoni zainfathoni changed the title Sharing State Between Components (@yaffalhakim1) Sharing State Between Components Apr 28, 2023
@yaffalhakim1
Copy link
Contributor

hi mas @zainfathoni looks like i making a mistake in my PR here because i still see my prev commit from my prev PR (which is merged). Do i need to create a new one or just continue the PR?

@zainfathoni
Copy link
Collaborator Author

It's up to you. If you know how to rebase your commits to the expected branch, you can keep this PR and "force push" your changes to it.

If you're not confident with it, you mau close this PR and raise a new one with the correct commits.

@yaffalhakim1
Copy link
Contributor

It's up to you. If you know how to rebase your commits to the expected branch, you can keep this PR and "force push" your changes to it.

If you're not confident with it, you mau close this PR and raise a new one with the correct commits.

I think I am fine with the first choice. Thank you, mas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants