Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate Warnings/unknown-prop #104

Merged
merged 2 commits into from Oct 4, 2019

Conversation

ismailnagib
Copy link
Contributor

Dear maintainers, please review the changes I've proposed in the PR and give me feedback. Thank you.

@netlify
Copy link

netlify bot commented Sep 26, 2019

Deploy preview for idreactjs ready!

Built with commit d731153

https://deploy-preview-104--idreactjs.netlify.com

@netlify
Copy link

netlify bot commented Sep 26, 2019

Deploy preview for id-reactjs ready!

Built with commit d731153

https://deploy-preview-104--id-reactjs.netlify.com

@ismailnagib ismailnagib changed the title add translation for warnings/unknown-prop Translate Warnings/Unknown-Prop Sep 27, 2019
Copy link
Member

@resir014 resir014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your help @ismailnagib!

Just one more thing, please update the PR to use the correct form of "Anda" (capitalised) before I can merge. 😄

@ismailnagib
Copy link
Contributor Author

I've submitted the requested changes. Thank you for the feedback! @resir014

@resir014 resir014 changed the title Translate Warnings/Unknown-Prop Translate Warnings/unknown-prop Oct 4, 2019
Copy link
Member

@resir014 resir014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now. Thanks for your help! ❤️

@resir014 resir014 merged commit eb54b3b into reactjs:master Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants