Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should we translate source code outputs and comments? #10

Closed
simsim0709 opened this issue Feb 9, 2019 · 4 comments
Closed

Should we translate source code outputs and comments? #10

simsim0709 opened this issue Feb 9, 2019 · 4 comments
Labels
discussion Discuss the problem.

Comments

@simsim0709
Copy link
Collaborator

screen shot 2019-02-10 at 12 07 15 am

Regarding the scope of translation, we need to discuss what to translate and what not to translate.

Any suggestion?
@simsim0709 simsim0709 mentioned this issue Feb 9, 2019
Closed
@ENvironmentSet
Copy link
Contributor

ENvironmentSet commented Feb 9, 2019 •
edited

I don't have any strong opinion about translating string values. But in my opinion, we'd better to translate source code comments since they are highly associated with contents of documents.

@cadenzah
Copy link
Contributor

cadenzah commented Feb 9, 2019

In my case, I translate only comments, nothing else.

@hg-pyun
Copy link
Member

hg-pyun commented Feb 10, 2019

I think it would be a good idea to translate the comment.

@hg-pyun hg-pyun added the discussion Discuss the problem. label Feb 10, 2019
@taehwanno
Copy link
Member

This will be fixed in #14

@taehwanno taehwanno mentioned this issue Feb 13, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discussion Discuss the problem.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@taehwanno @simsim0709 @hg-pyun @cadenzah @ENvironmentSet