Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR merge rule and PR template suggestion #23

Closed
gnujoow opened this issue Feb 12, 2019 · 11 comments
Closed

PR merge rule and PR template suggestion #23

gnujoow opened this issue Feb 12, 2019 · 11 comments
Assignees
Labels
discussion Discuss the problem.

Comments

@gnujoow
Copy link
Member

gnujoow commented Feb 12, 2019

pr merge

Since no PR has been merged yet, I think it would be good to make rule for merging PR.

pr template

<!--

Thank you for the PR! Contributors like you keep React awesome!

Please see the Contribution Guide for guidelines:

https://github.com/reactjs/reactjs.org/blob/master/CONTRIBUTING.md

If your PR references an existing issue, please add the issue number below

-->

here is the current PR template, but if the checklist is included here, contributors and reviewers can check the progress of the PR so it can bring better communicate better.

@gnujoow
Copy link
Member Author

gnujoow commented Feb 12, 2019

for PR mege I suggest PR is merged if it has (at least) two approve from reviewer or maintainer to check the quality of the translation.

2019-02-12 10 50 40

@gnujoow
Copy link
Member Author

gnujoow commented Feb 12, 2019

<!--

Thank you for the PR! Contributors like you keep React awesome!

Please see the Contribution Guide for guidelines:

https://github.com/reactjs/reactjs.org/blob/master/CONTRIBUTING.md

If your PR references an existing issue, please add the issue number below

-->

**progress**  

[ ] 번역 초안 작성
[ ] glossary 용어 확인 (wiki or issue links)
[ ] 띄어쓰기 검사 (http://speller.cs.pusan.ac.kr/)
[ ] 리뷰 반영
[ ] 최종 PR

if this checklist included in template, I think this will be able to help contributors to check their tranlation progress.

@gnujoow gnujoow added TIP Useful informations. discussion Discuss the problem. and removed TIP Useful informations. labels Feb 12, 2019
@taehwanno
Copy link
Member

taehwanno commented Feb 12, 2019

for PR mege I suggest PR is merged if it has (at least) two approve from reviewer or maintainer to check the quality of the translation.

I agree :)

if this checklist included in template, I think this will be able to help contributors to check their tranlation progress.

Good idea. We need to add UNIVERSAL-STYLE-GUIDE.md in #17.

@hg-pyun
Copy link
Member

hg-pyun commented Feb 13, 2019

Yeah, It is a very coool idea.

@taggon
Copy link
Collaborator

taggon commented Feb 13, 2019

I think the third item should be "맞춤법 검사" rather than "띄어쓰기 검사", as the online tool checks more than spacing.

@cadenzah
Copy link
Contributor

cadenzah commented Feb 13, 2019

The idea of progress items is pretty nice. It will be easier to check important stuffs.

@taehwanno
Copy link
Member

I applied "Require pull request reviews before merging" with options in the screenshot.

@simsim0709
Copy link
Collaborator

I agree 👍

@gnujoow
Copy link
Member Author

gnujoow commented Feb 15, 2019

I will close this issue and make PR for PR templete this sunday. if there is any feed back on the checklist, comment on this thread by this week.

@taggon
Copy link
Collaborator

taggon commented Feb 17, 2019

The current PR template, which introduced by #25, contains broken links. If we don't have appropriate references for the items yet, it would be better to remove the links.

image

@gnujoow
Copy link
Member Author

gnujoow commented Feb 21, 2019

@taggon I've just made pr to resolve the issue you mention.
#45

@gnujoow gnujoow closed this as completed Feb 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Discuss the problem.
Projects
None yet
Development

No branches or pull requests

6 participants