Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to add lost original text translation #272

Closed
taehwanno opened this issue Dec 13, 2020 · 1 comment
Closed

Need to add lost original text translation #272

taehwanno opened this issue Dec 13, 2020 · 1 comment

Comments

@taehwanno
Copy link
Member

Related to #270 (comment)

When I'm resolving syn pull request #270, I find that some original text are lost. we need to add translation.

React.Component's componentDidCatch

Production and development builds of React slightly differ in the way componentDidCatch() handles errors.

On development, the errors will bubble up to window, this means that any window.onerror or window.addEventListener('error', callback) will intercept the errors that have been caught by componentDidCatch().

On production, instead, the errors will not bubble up, which means any ancestor error handler will only receive errors not explicitly caught by componentDidCatch().
@taggon
Copy link
Collaborator

taggon commented Oct 21, 2021

Closed as this issue has already been resolved by #280

@taggon taggon closed this as completed Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants