Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'jsx' code annotation changed to 'js' #78

Merged
merged 1 commit into from Jun 29, 2017

Conversation

benwiley4000
Copy link
Contributor

js is recognized by npmjs.com (jsx isn't) and there was no JSX here anyway.

'js' is recognized by npmjs.com ('jsx' isn't) and there was no JSX here anyway.
@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@benwiley4000
Copy link
Contributor Author

I signed it! Thanks

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@ljharb
Copy link
Collaborator

ljharb commented Jun 12, 2017

Thanks - can you file a bug on npm's markdown parser so it understands jsx, and link it here?

@benwiley4000
Copy link
Contributor Author

benwiley4000 commented Jun 12, 2017 via email

@ljharb
Copy link
Collaborator

ljharb commented Jun 12, 2017

:-) Totally agree

Copy link
Contributor

@aweary aweary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@aweary aweary merged commit be165fe into facebook:master Jun 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants