New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
'jsx' code annotation changed to 'js' #78
Conversation
'js' is recognized by npmjs.com ('jsx' isn't) and there was no JSX here anyway.
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
I signed it! Thanks |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Thanks - can you file a bug on npm's markdown parser so it understands jsx, and link it here? |
I can do that - and I also think this should be changed from jsx, since
it's not JSX. ;)
Unless I misunderstand what the jsx parser does.
P.S. here it is: npm/marky-markdown#395
…On Jun 12, 2017 2:15 AM, "Jordan Harband" ***@***.***> wrote:
Thanks - can you file a bug on npm's markdown parser so it understands
jsx, and link it here?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#78 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AM7h7Z3JteJHS2OnH3ps9Dfs78EB6MSQks5sDNeLgaJpZM4N2r5S>
.
|
:-) Totally agree |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
js
is recognized by npmjs.com (jsx
isn't) and there was no JSX here anyway.