Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOM Virtual e Objetos Internos #159

Merged
merged 8 commits into from Mar 15, 2019
Merged

DOM Virtual e Objetos Internos #159

merged 8 commits into from Mar 15, 2019

Conversation

WeslleyNasRocha
Copy link
Contributor

No description provided.

@WeslleyNasRocha WeslleyNasRocha mentioned this pull request Mar 11, 2019
Closed
90 tasks
@netlify
Copy link

netlify bot commented Mar 11, 2019

Deploy preview for pt-br-reactjs ready!

Built with commit a4c1713

https://deploy-preview-159--pt-br-reactjs.netlify.com

@netlify
Copy link

netlify bot commented Mar 11, 2019 •
edited

Deploy preview for pt-br-reactjs ready!

Built with commit 3fbf7ea

https://deploy-preview-159--pt-br-reactjs.netlify.com

jhonmike
jhonmike reviewed Mar 11, 2019
View reviewed changes
Copy link
Member

@jhonmike jhonmike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefiro Virtual DOM do que DOM Virtual, nunca vi ninguém traduzir esse termo.

content/docs/faq-internals.md Outdated Show resolved Hide resolved
@jhonmike
Copy link
Member

mandei algumas considerações na review, aguardo sua resposta, e logo em seguida podemos dar merge, no mais acho q ficou ótimo!

@jhonmike jhonmike added needs review A pull request ready to be reviewed needs author response Changes requested needing author's input labels Mar 11, 2019
@tibuurcio tibuurcio mentioned this pull request Mar 11, 2019
Closed
13 tasks
@jhonmike jhonmike added needs +1 Needs another approval before merging and removed needs author response Changes requested needing author's input needs review A pull request ready to be reviewed labels Mar 11, 2019
jhonmike
jhonmike previously approved these changes Mar 11, 2019
View reviewed changes
Copy link
Member

@jhonmike jhonmike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏆

halian-vilela
halian-vilela requested changes Mar 13, 2019
View reviewed changes
Copy link
Collaborator

@halian-vilela halian-vilela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WeslleyNasRocha

Grande Weslley!

Fiz só algumas pequenas sugestões para manter a proximidade com o texto original ou deixar alguns conceitos mais precisos.

Dê uma olhada anos ajustes propostos e já aprovaremos sua contribuição!

Muito obrigado!

content/docs/faq-internals.md Outdated Show resolved Hide resolved
content/docs/faq-internals.md Outdated Show resolved Hide resolved
content/docs/faq-internals.md Outdated Show resolved Hide resolved
content/docs/faq-internals.md Outdated Show resolved Hide resolved
@halian-vilela halian-vilela added needs author response Changes requested needing author's input and removed needs +1 Needs another approval before merging labels Mar 13, 2019
@jhonmike jhonmike self-requested a review March 13, 2019 02:34
@halian-vilela @WeslleyNasRocha
Apply suggestions from code review
baf4861 
Co-Authored-By: WeslleyNasRocha <weslleytato.12@gmail.com>
@WeslleyNasRocha WeslleyNasRocha dismissed stale reviews from jhonmike via baf4861 March 13, 2019 12:49
jhonmike
jhonmike requested changes Mar 15, 2019
View reviewed changes
Copy link
Member

@jhonmike jhonmike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

faltou apenas esse item aqui:

content/docs/faq-internals.md Outdated Show resolved Hide resolved
@WeslleyNasRocha
Update content/docs/faq-internals.md
3fbf7ea 
opa

Co-Authored-By: WeslleyNasRocha <weslleytato.12@gmail.com>
@jhonmike jhonmike merged commit 7799fb8 into reactjs:master Mar 15, 2019
@jhonmike jhonmike added the 🌐 translated Translation is completed for this page label Mar 15, 2019
@jhonmike jhonmike removed the needs author response Changes requested needing author's input label Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@halian-vilela halian-vilela halian-vilela requested changes

@jhonmike jhonmike jhonmike approved these changes

Assignees
No one assigned
Labels
🌐 translated Translation is completed for this page
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@WeslleyNasRocha @jhonmike @halian-vilela