Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate Test Utilities #81

Merged
merged 1 commit into from Feb 12, 2019
Merged

Translate Test Utilities #81

merged 1 commit into from Feb 12, 2019

Conversation

luizbraga
Copy link
Contributor

@luizbraga luizbraga commented Feb 11, 2019

#1

@WendellAdriel WendellAdriel added the needs review A pull request ready to be reviewed label Feb 11, 2019
Copy link
Member

@glaucia86 glaucia86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@glaucia86 glaucia86 added the needs +1 Needs another approval before merging label Feb 12, 2019
>
> We recommend using [`react-testing-library`](https://git.io/react-testing-library) which is designed to enable and encourage writing tests that use your components as the end users do.
> Nós recomendamos usar [`react-testing-library`](https://git.io/react-testing-library) que é projetado para permitir e encorajar escrita de testes que utilizam seus componentes como os usuários finais utilizarão.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Num sabia que o React team tava sugerindo a galera usar react-testing-library, da ultima vez que eu li isso eles sugeriram somente Enzyme.

@eduardomoroni eduardomoroni merged commit 0a7ecc4 into reactjs:master Feb 12, 2019
@eduardomoroni
Copy link
Member

Valeu @luizbraga

@cezaraugusto cezaraugusto added 🌐 translated Translation is completed for this page and removed needs +1 Needs another approval before merging needs review A pull request ready to be reviewed labels Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌐 translated Translation is completed for this page
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants