Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brazilian Portuguese Translation Final Tasks! #123

Closed
7 of 10 tasks
tesseralis opened this issue Feb 23, 2019 · 17 comments
Closed
7 of 10 tasks

Brazilian Portuguese Translation Final Tasks! #123

tesseralis opened this issue Feb 23, 2019 · 17 comments
Assignees

Comments

@tesseralis
Copy link
Member

tesseralis commented Feb 23, 2019

Congratulations!

You all are almost done translating the React docs into Portuguese! There are couple more errands to do before we can mark the project as "completed"

  • Replace "reactjs.org" to "pt-br.reactjs.org" in the following places:
    • package.json
    • site-constants.js
    • gatsby-config.js
    • MarkdownPage (the link href in "Edit this page")
  • Change html.js to have the attribute lang="pt-BR"
  • Go over each section in the site to:
    • Make sure there are no formatting errors (dangling markdown/html tags) or untranslated English
    • Make sure the sections and style are consistent.
  • Change the DocSearch API key. One of the maintainers needs to sign up for DocSearch ( Updates DocSearch apiKey and indexName #132)

We're almost there everyone!

@halian-vilela
Copy link
Collaborator

@tesseralis

Hey Nat! Will this have any immediate effect on something?

I mean, should we wait to have at least all the core pages done to make this changes or could we do it now just to make sure it will be ready?

Thanks!

@tibuurcio
Copy link
Collaborator

tibuurcio commented Feb 23, 2019

Thank you for pointing our last steps @tesseralis! We're almost there indeed 🎉

I've made some of the changes on #124. I've also signed up for the DocSearch key, will comment here when we get their response.

EDIT: Just seen our documentation is already live! That's awesome 😄

@glaucia86
Copy link
Member

@tesseralis awesome. We have to say thank you for all the brazilian community help. It was insane. But we will see about the topics that you listed it and then finish this issue. :)

@tesseralis
Copy link
Member Author

@halian-vilela hmm. I think I'd wait until a certain section (like "main concepts") is completed, and then go over all of it to see if the whole thing feels consistent.

@WendellAdriel
Copy link
Member

These items listed by @tesseralis, can I help with any of these or is there someone already doing that?

@WendellAdriel
Copy link
Member

That's awesome, sorry to be away guys, but I had some personal issues that took a lot of my free time

@glaucia86
Copy link
Member

@WendellAdriel you can take it this one:

* Change the [DocSearch API key](https://github.com/reactjs/es.reactjs.org/blob/ed07fa53dc9ab7950e630900f7da3a7c821d63a6/src/components/LayoutHeader/DocSearch.js#L25). **Signed up. Waiting for DocSearch API Key** One of the maintainers needs to [sign up for DocSearch](https://community.algolia.com/docsearch/#join-docsearch-program)

@WendellAdriel
Copy link
Member

Great @glaucia86, I'll do that then!!!
Has any of the other maintainers signed up already for DocSearch?

@tibuurcio
Copy link
Collaborator

tibuurcio commented Feb 25, 2019

Hi everyone. I've already signed for DocSeach. I'm awaiting for their response and will comment here. We will probably hear from them this week since I applied on the weekend. Cheers!

@glaucia86 @WendellAdriel

The task of going through each section will be challenging, maybe we should plan how we can do it. What do you guys think?

@tesseralis
Copy link
Member Author

@tibuurcio awesome! I just got the email from the Spanish repo after around a week. Shouldn't take too long.

@michellocana
Copy link
Contributor

michellocana commented Feb 26, 2019

I have a little hack i used to make suggestions in PR's, and this can be useful to spot untranslated/misspelled words:

document.designMode = 'on' 
// focus on some text or scroll the page, and you will see autocorrect suggestions 
document.designMode = 'off'

@tibuurcio
Copy link
Collaborator

Got the email from DocSearch yesterday already! I'll update our code as soon as I can :)

@tesseralis
Copy link
Member Author

@tibuurcio I'm sorting out issues with docsearch for spanish here: reactjs/es.react.dev#184 (comment)

it may be useful to you

@eduardomoroni
Copy link
Member

  • Go over each section in the site to:
    • Make sure there are no formatting errors (dangling markdown/html tags) or untranslated English
    • Make sure the sections and style are consistent.

I'm pointing some items out on #134
I'll need some help on that as well :)

@glaucia86
Copy link
Member

@eduardomoroni about the #134 I already did a code review about the Nav bar situation and I asked to the contributor to make some changes on it! So... he did it and I already approve the contribution #131. Try to see right now @eduardomoroni if everything it's correct right now! ;)

@eduardomoroni
Copy link
Member

eduardomoroni commented Mar 8, 2019

It seems everything all right. Should wemark this as done?

@glaucia86
Copy link
Member

It seems everything all right. Should wemark this as done?

bitmoji

Agree w/ u @eduardomoroni. Let's finish this translation! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants