Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert internal link translations #42

Closed
cezaraugusto opened this issue Feb 9, 2019 · 8 comments
Closed

Revert internal link translations #42

cezaraugusto opened this issue Feb 9, 2019 · 8 comments
Labels
help wanted Task that needs owner

Comments

@cezaraugusto
Copy link
Member

cezaraugusto commented Feb 9, 2019

Some PRs got accepted including internal link translations which we later decided not to translate.

By internal links, we are referring to these:
e.g.

Overview (#overview)

That should be translated to

Visão Geral (#overview)

External links (MDN, Wikipedia, etc.) should link to the Portuguese version, if available.

The task here is to go through this list and check what links have been translated and undo that.

Either a PR for each document or a PR bundle with all reverts are valid and up to the author what to choose

@fjoshuajr
Copy link
Collaborator

fjoshuajr commented Feb 9, 2019

Ok, can you be more specific on your message about what links we are talking about here? Just to avoid confusion.

Edit: Edited OP post.

@victorsilent
Copy link
Contributor

Ok, can you be more specific on your message about what links we are talking about here? Just to avoid confusion.

For sure, some links has just a english name link this one:
[state of the art algorithms](http://grfia.dlsi.ua.es/ml/algorithms/references/editsurvey_bille.pdf)
but could be translated without problems I guess, what do you think?

@fjoshuajr fjoshuajr changed the title Revert link translations Revert internal link translations Feb 9, 2019
@cezaraugusto
Copy link
Member Author

yes the link names are fine to translate but not the URL they refer to. even if they're just anchors

@glaucia86
Copy link
Member

@tibuurcio
Copy link
Collaborator

tibuurcio commented Feb 10, 2019

Maybe we should translate the universal style guide into our own guide to make sure everyone has easy access to it? In the meantime I submitted #58 which fixes some PR's I could find with links translated.

I couldn't find any more wrong links in the list of closed PR's. If someone else could take a look at the list, we could close this issue after #58 merges 😄

@glaucia86
Copy link
Member

agree @tibuurcio.

cc: guys what do you think about it?

@fjoshuajr
Copy link
Collaborator

Yes, we could merge the universal style guide with the glossary, so we can have one file with all the rules.

@fjoshuajr
Copy link
Collaborator

fjoshuajr commented Feb 11, 2019

Fechando a issue a favor de #69.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Task that needs owner
Projects
None yet
Development

No branches or pull requests

5 participants