Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dynamic context type names fail the whole file #317

Closed
giladv opened this issue Dec 22, 2018 · 2 comments · Fixed by #340
Closed

dynamic context type names fail the whole file #317

giladv opened this issue Dec 22, 2018 · 2 comments · Fixed by #340
Labels
bug has-PR

Comments

@giladv
Copy link

giladv commented Dec 22, 2018

3.X

dynamic context type names fail the whole file

static contextTypes = {
    [DYNAMIC_NAME]: ...
}

TypeError: Property name must be an Identifier or a Literal

why fail the entire file?
a warning + moving to the next prop/context type should be the way to go.

thanks.
@wwsun
Copy link

wwsun commented Jan 9, 2019

any solutions?

@priley86
Copy link

bumping up against this one too. Any chance we can suppress this?

@atiratree atiratree mentioned this issue Mar 22, 2019
Merged
6 tasks
@danez danez mentioned this issue Apr 11, 2019
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug has-PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Handle computed properties correctly and do not fail generation reactjs/react-docgen
4 participants
@danez @giladv @priley86 @wwsun