Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recommendations for integrating with Sphinx #7

Closed
woodb opened this issue Mar 18, 2015 · 4 comments
Closed

Recommendations for integrating with Sphinx #7

woodb opened this issue Mar 18, 2015 · 4 comments
Labels

Comments

@woodb
Copy link

woodb commented Mar 18, 2015

I was wondering if there were any recommendations or gists out there for using this in conjunction with Sphinx?

@fkling
Copy link
Member

fkling commented Mar 18, 2015

I'm not familiar with Sphinx, but at a first glance, you might want to look at the "JavaScript domain".

Instead of e.g. generating markdown from the result JSON/JS object (as shown in the example), you would generate an output that conforms to that syntax and then feed it to Sphinx.

If someone more familiar with Sphinx wants to provide a generator that does that, I'm more than happy to link to it in the wiki*.


*: We could have a wiki page that links to tools which can consume the output of react-docgen.

@woodb
Copy link
Author

woodb commented Mar 18, 2015

Ah sweet! I didn't see the markdown generator. Sphinx prefers reStructuredText, so maybe the most reasonable way to implement this would be to simply make a generator that produces rST... I'll try my hand at it and keep you apprised, thanks.

@fkling
Copy link
Member

fkling commented Mar 18, 2015

Awesome 👍

I'm not familiar with reStructuredText either, but yes, if Sphinx can work with any reStructuredText, that would work as well!

Also keep in mind that you can use any "markup" language in the component and prop types comments as long as your conversion process understands it.


In general, I think it's more useful if any step produces a rather generic intermediated format that can be consumed by other tools. That's why react-docgen produces JSON and not markdown for example. Similar here, if one creates a converter to reStructuredText, any tool that can consume reStructuredText can be used, not just Sphinx.

@woodb
Copy link
Author

woodb commented Mar 18, 2015

Thanks @fkling, closing this one following the creation #8.

@woodb woodb closed this as completed Mar 18, 2015
birjj added a commit to birjj/react-docgen that referenced this issue Jun 27, 2017
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants