Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OnClick event clash with AgGrid v26.1 #424

Closed
ATrogolo opened this issue Oct 11, 2021 · 2 comments · May be fixed by peachfinance/redoc#10
Closed

OnClick event clash with AgGrid v26.1 #424

ATrogolo opened this issue Oct 11, 2021 · 2 comments · May be fixed by peachfinance/redoc#10
Labels

Comments

@ATrogolo
Copy link

ATrogolo commented Oct 11, 2021

Hi,
I've found an incompatibility with the last update of with AgGrid library (v.26.1.0).

The issue appears when a react-tabs component contains an ag-grid.
The issue is triggered by the onClick event when selecting a column menu item (general / filter / columns) (https://www.ag-grid.com/javascript-data-grid/column-menu/#example-column-menu).

React-tabs has a method to check if the click event belongs to the component.
To perform this check it checks if the "target" item has a role === 'tab'.

Now, the AgGrid 'button' of the column item menu has attribute role = "tab" too and it clashes with your check.

Packages versions:

  • ag-grid: 26.1.0
  • react-tabs (both 3.0.0 and latest: 3.2.2)

Could you consider an update to your method?
This issue could affect all ag-grid and react-tabs users.

Here a repository which reproduce the issue: https://github.com/ATrogolo/aggrid-v26.1-react-tabs-clash

Please let me know what you think about this.
Andrea

@danez danez closed this as completed in 517a056 Oct 28, 2021
@danez
Copy link
Collaborator

danez commented Oct 28, 2021

Sorry it took so long, it should be fixed now. New version is 3.2.3

@github-actions
Copy link

🎉 This issue has been resolved in version 3.2.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants