Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: enter animations with mountOnEnter or unmountOnExit #749

Merged
merged 4 commits into from
Jul 30, 2022
Merged

fix: enter animations with mountOnEnter or unmountOnExit #749

merged 4 commits into from
Jul 30, 2022

Conversation

koba04
Copy link
Member

@koba04 koba04 commented Jul 25, 2021 •
edited
Loading

fixes #745
This fixes enter animations with mountOnEnter or unmounOnExit. However, this might introduce other issues like unexpected animations, so I have to test this before this gets merged.

@rilexus rilexus mentioned this pull request Jul 31, 2021
Closed
@koba04 koba04 marked this pull request as ready for review August 1, 2021 04:37
@koba04
Copy link
Member Author

koba04 commented Aug 1, 2021

I've added more stories for CSSTransition and it seems to work fine.
I've found some issues around TransitionGroup and couldn't figure out whether Transition should mount an element with unmountOnExit and without mountOnEnter or not. Currently, it's not mounted.
But I think this is another issue, so I won't fix it in this issue.

@koba04
Copy link
Member Author

koba04 commented Aug 1, 2021

This introduces an additional render because performEnter is no longer batched.

@anatolzak
Copy link

Hi @koba04.

Thanks again for working on this pull request to fix the bug that I reported.

Is there perhaps a timeline to when this pull request will be merged into the main branch?

@koba04
Copy link
Member Author

koba04 commented Aug 16, 2021

@anatolzak
I don't have any timeline to merge this yet because it has a risk to cause other problems caused by an additional render to make this animation happen.
But I'll try to work to be able to merge this.

@Taelar
Copy link

Taelar commented Feb 11, 2022

Hi, any update on that ? I'm really interested in that fix

@koba04
Copy link
Member Author

koba04 commented Feb 12, 2022

I'll check it again.

@koba04 koba04 force-pushed the fix-enter-animation-with-unmountonexit branch 2 times, most recently from 16f548d to 5478f34 Compare February 15, 2022 14:39
@koba04 koba04 changed the title fix: entering animations with unmountOnExit fix: enter animations with mountOnEnter and unmountOnExit Feb 15, 2022
@koba04 koba04 changed the title fix: enter animations with mountOnEnter and unmountOnExit fix: enter animations with mountOnEnter or unmountOnExit Feb 15, 2022
@koba04 koba04 force-pushed the fix-enter-animation-with-unmountonexit branch from 5478f34 to 42616bd Compare February 15, 2022 14:40
@koba04 koba04 requested a review from eps1lon February 15, 2022 14:40
@koba04
Copy link
Member Author

koba04 commented Feb 15, 2022 •
edited
Loading

I've reworked this to get merged and requested reviewing.

@Taelar
Copy link

Taelar commented May 25, 2022

Hi again, thanks for working on this !
Do you have an idea of when this will be reviewed/merged ?

koba04
koba04 commented May 26, 2022
View reviewed changes
stories/CSSTransition.js Outdated Show resolved Hide resolved
@koba04
Copy link
Member Author

koba04 commented May 26, 2022

@eps1lon Could you review this PR?

@danantal
Copy link

Hi guys

I am also pretty interested in this fix - so would be amazing if it can be moved further :)

@koba04
Copy link
Member Author

koba04 commented Jul 30, 2022

I think I had enough time to get feedback, so I'll merge this.

@koba04 koba04 merged commit 51bdceb into reactjs:master Jul 30, 2022
@koba04 koba04 deleted the fix-enter-animation-with-unmountonexit branch July 30, 2022 13:06
github-actions bot pushed a commit that referenced this pull request Jul 30, 2022
@semantic-release-bot
chore(release): 4.4.3 [skip ci]
01dcc83 
## [4.4.3](v4.4.2...v4.4.3) (2022-07-30)

### Bug Fixes

* enter animations with mountOnEnter or unmountOnExit  ([#749](#749)) ([51bdceb](51bdceb))
@github-actions
Copy link

🎉 This PR is included in version 4.4.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Mookiepiece Mookiepiece mentioned this pull request Jul 31, 2022
Closed
@koba04 koba04 mentioned this pull request Aug 1, 2022
Merged
johnfrench3 pushed a commit to johnfrench3/transition-group-react that referenced this pull request Nov 2, 2022
chore(release): 4.4.3 [skip ci]
d4b5375 
## [4.4.3](reactjs/react-transition-group@v4.4.2...v4.4.3) (2022-07-30)

### Bug Fixes

* enter animations with mountOnEnter or unmountOnExit  ([#749](reactjs/react-transition-group#749)) ([51bdceb](reactjs/react-transition-group@51bdceb))
patrickm68 added a commit to patrickm68/react-transition-group-developer that referenced this pull request Dec 1, 2022
@patrickm68
chore(release): 4.4.3 [skip ci]
d4f592a 
## [4.4.3](reactjs/react-transition-group@v4.4.2...v4.4.3) (2022-07-30)

### Bug Fixes

* enter animations with mountOnEnter or unmountOnExit  ([#749](reactjs/react-transition-group#749)) ([51bdceb](reactjs/react-transition-group@51bdceb))
@snyk-bot snyk-bot mentioned this pull request Mar 3, 2023
Open
shaikdev2 pushed a commit to shaikdev2/transition-group-react that referenced this pull request Jun 9, 2023
@paxaxel223
chore(release): 4.4.3 [skip ci]
082ccfe 
## [4.4.3](reactjs/react-transition-group@v4.4.2...v4.4.3) (2022-07-30)

### Bug Fixes

* enter animations with mountOnEnter or unmountOnExit  ([#749](reactjs/react-transition-group#749)) ([51bdceb](reactjs/react-transition-group@51bdceb))
GreenCat1996 added a commit to GreenCat1996/react-transition-group that referenced this pull request Aug 1, 2023
@GreenCat1996
chore(release): 4.4.3 [skip ci]
b9d6aea 
## [4.4.3](reactjs/react-transition-group@v4.4.2...v4.4.3) (2022-07-30)

### Bug Fixes

* enter animations with mountOnEnter or unmountOnExit  ([#749](reactjs/react-transition-group#749)) ([51bdceb](reactjs/react-transition-group@51bdceb))
@aztek aztek mentioned this pull request Jul 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eps1lon eps1lon Awaiting requested review from eps1lon

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Transition enter animation doesn't work correctly with unmountOnExit
4 participants
@koba04 @anatolzak @Taelar @danantal