Skip to content
This repository has been archived by the owner on Jul 19, 2019. It is now read-only.

Race condition in refresh code #130

Closed
daxfohl opened this issue Apr 10, 2016 · 1 comment
Closed

Race condition in refresh code #130

daxfohl opened this issue Apr 10, 2016 · 1 comment

Comments

@daxfohl
Copy link

daxfohl commented Apr 10, 2016

If you POST a new comment at the same time you poll, the optimistic GUI update occurs, then if the poll returns before the POST, it'll cause the comment on the GUI to disappear again until the POST returns. So you get a little flash before the comment appears permanently.

@zpao
Copy link
Member

zpao commented Apr 11, 2016

Thanks for noticing, you are now ready to go build your own version that handles that better 😀. This is not meant to be a production ready and resilient application, only an example for educative purposes. We wanted to focus on the React part as much as possible and not spend too much time making a big deal about the data fetching and server-side aspects.

@zpao zpao closed this as completed Apr 11, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants