Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code Editor layout broken for smaller screen sizes #54

Closed
bvaughn opened this issue Oct 7, 2017 · 3 comments · Fixed by #58
Closed

Code Editor layout broken for smaller screen sizes #54

bvaughn opened this issue Oct 7, 2017 · 3 comments · Fixed by #58
Labels
difficulty: beginner good first issue in-progress type: website

Comments

@bvaughn
Copy link
Contributor

bvaughn commented Oct 7, 2017

Not sure when this happened but it looks like our CSS got a little broken:
screen-shot-2017-10-07-at-9 22 41-am

screen-shot-2017-10-07-at-9 24 49-am
@fpoumian fpoumian mentioned this issue Oct 7, 2017
Merged
@cyan33
Copy link
Contributor

cyan33 commented Oct 7, 2017

Can I work on this?

And just want to make sure:

  1. the top-right and bottom-right radius are misssing
  2. the gap should not appear

Is that right? @bvaughn Thanks for your explanation!

@cyan33 cyan33 mentioned this issue Oct 7, 2017
Closed
@bvaughn
Copy link
Contributor Author

bvaughn commented Oct 7, 2017

Hey @thomasyimgit ! Sorry I didn't see this until now but PR #58 was submitted 5 hours ago with a fix. Thanks though! Maybe another issue?

@cyan33
Copy link
Contributor

cyan33 commented Oct 7, 2017

@bvaughn That's alright, I'll see what I can help with others.

jhonmike pushed a commit to jhonmike/reactjs.org that referenced this issue Jul 1, 2020
@ukita @eduardomoroni
Translate: Add React to a Website (reactjs#54)
ca486dd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty: beginner good first issue in-progress type: website
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Code Editor layout in Smaller Screen Sizes fpoumian/reactjs.org
2 participants
@bvaughn @cyan33