-
Notifications
You must be signed in to change notification settings - Fork 945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source map request return 500 when using MsieJavaScriptEngine #53
Comments
This is expected, the older MSIE engine can't generate source maps. The source map code in JSXTransformer has this comment above it:
JSXHandler tries the best it can to generate source maps. I had to intentionally disable
This is a good idea, I could probably just do a basic check based on the current engine - Enable it for everything except MSIE. |
Also you can use the V8 engine (via |
@Daniel15 thanks for you advise. I may change to V8 if it is great. Besides, I have sent a PR to disable source map if it is MSIE which I have tested locally. Please take a look. |
Is there a way to force V8 (or disabling sourcemaps for MSIE)? I couldn't find a way to specify the engine. |
Same here, getting HTTP 500 (Unable to generate source map) in chrome... |
@ashic Installing |
Yep installing ClearScriptV8 fixed it for me... |
+1. Installed React.JavaScriptEngine.ClearScriptV8 via nuget to my MVC project and the 500 errors went away. Thanks! |
Closing this out since V8 (ClearScript / VroomJs) is bundled by default now. |
After long time investigation, the following statement returns different output in IE10 and IE11:
In IE11, which looks fine (notices that
sourceMap
object is generated):In IE10, suck... the
sourceMap
gone :(When using MSIE JavaScript switcher in Json.Net, it is running in
ChakraActiveScript
mode, its document saysChakraJsRt
mode leverage IE11. While I try with this way, but it does not work, still inChakraActiveScript
mode.Any idea on this?
Besides, I think when send transformed JSX, it should check if it can generate source map before set the JSX header.
The text was updated successfully, but these errors were encountered: