Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document error boundaries #17

Closed
bvaughn opened this issue Oct 6, 2017 · 3 comments
Closed

Document error boundaries #17

bvaughn opened this issue Oct 6, 2017 · 3 comments

Comments

@bvaughn
Copy link
Contributor

bvaughn commented Oct 6, 2017

Add top-level documentation for the new componentDidCatch lifecycle. Please refer to the post:

https://reactjs.org/blog/2017/07/26/error-handling-in-react-16.html

It describes the behavior in detail. We should just adopt it to the doc format.

This issue has been claimed by @krizzu

@lydell
Copy link

lydell commented Oct 10, 2017

This seems to exist now: https://reactjs.org/docs/error-boundaries.html

Question: Should componentDidCatch be briefly mentioned in https://reactjs.org/docs/react-component.html and link to the above page?

@bvaughn
Copy link
Contributor Author

bvaughn commented Oct 10, 2017

Yup! A PR was merged without referencing this issue I guess. Thanks for pointing out the oversight 😄

I've opened #120 for adding componentDidCatch ~ if you want it, leave a comment there and it's all yours 😄

@yugandhar-pathi
Copy link

Can some one help me to decipher stack trace. I have stack trace ready but no idea how to actually read that.

Here is the error stack received from production mode..
This error is located at:
in t
in RCTSafeAreaView
in r
in r
in Connect(r)
in t
in RCTView
in n
in t
in n
in RCTView
in RCTView
in t
in RCTView
in e
in r
in Unknown
in n
in n
in t
in RCTView
in n
in t
in n
in RCTView
in RCTView
in t
in RCTView
in e
in r
in Unknown
in n
in n
in t
in RCTView
in RCTView
in t
in RCTView
in RCTView
in n
in t
in RCTView
in t
in r
in withCachedChildNavigation(r)
in Unknown
in n
in n
in t
in t
in withCachedChildNavigation(t)
in Unknown
in n
in n
in Unknown
in Connect(Component)
in n
in e
in t
in RCTView
in RCTView
in t

jhonmike pushed a commit to jhonmike/reactjs.org that referenced this issue Jul 1, 2020
* translate typechecking with proptypes page

* translate "package" to "pacote" when referring to npm

Co-Authored-By: lucasdeassis <lucasassis413@gmail.com>

* Update "built-in" translation to "nativas"

Co-Authored-By: lucasdeassis <lucasassis413@gmail.com>

* change translation on "React component class"

* adding common english terms in parenthesis

* Update "using" translation

Co-Authored-By: lucasdeassis <lucasassis413@gmail.com>

* Update "defaultProps" gender translation

Co-Authored-By: lucasdeassis <lucasassis413@gmail.com>

* Update url to babel plugin reference

Co-Authored-By: lucasdeassis <lucasassis413@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants