Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Flow types to website source #24

Open
bvaughn opened this issue Oct 6, 2017 · 16 comments
Open

Add Flow types to website source #24

bvaughn opened this issue Oct 6, 2017 · 16 comments

Comments

@bvaughn
Copy link
Contributor

bvaughn commented Oct 6, 2017

Replace PropTypes with Flow types for our components in www (and make sure yarn flow checks these types to protect against regressions).

I got the ball rolling with commit 1de4c66

This Twitter thread also has some interesting discussion for auto-generating Flow types for Gatsby's graphql queries.

@hd719
Copy link

hd719 commented Oct 11, 2017

Hey sorry @bvaughn is this now closed?
Actually never mind, I looked at it wrong, the issue #10897 is closed. Sorry about that

@bvaughn
Copy link
Contributor Author

bvaughn commented Oct 11, 2017

No problem. 😄 Are you interested in helping out with this issue? Lots of work to be done here. Could be cool!

@hd719
Copy link

hd719 commented Oct 11, 2017

Hey @bvaughn yes I am still kind of new to open source and still learning Flow Types, but yes I would like to help out on this particular issue.

@bvaughn
Copy link
Contributor Author

bvaughn commented Oct 11, 2017

Okay! Great.

This is a pretty big issue, so my advice is- let's do it a couple files at a time. That way it's easier to review and we don't risk conflicting with every other PR.

@hd719
Copy link

hd719 commented Oct 11, 2017

Sounds good!

@tricinel
Copy link
Contributor

tricinel commented Oct 13, 2017

I can help as well. Going through a couple of files at a time seems like a good idea.

@bvaughn
Copy link
Contributor Author

bvaughn commented Oct 13, 2017

Okay. I'll mark this issue in-progress.

Communicate here to avoid stepping on each other's toes. 😄

@tricinel
Copy link
Contributor

Awesome. I've already opened a PR for it (but forgot to mention the issue number on the commit): #156. Sorry about that. Perhaps if it checks out, then it can be merged so that we keep on top of it and avoid conflicts as much as possible?

I'd like to continue working on it though. So I can continue on it next week if that's ok. I'll work through the src/components files first.

Do you think it's worth doing the utils as well? Adding flow typechecking there as well?

@bvaughn
Copy link
Contributor Author

bvaughn commented Oct 16, 2017

Do you think it's worth doing the utils as well? Adding flow typechecking there as well?

Yeah 😄

bvaughn added a commit that referenced this issue Oct 20, 2017
Switch to flow types; wip related to #24
bvaughn added a commit that referenced this issue Nov 29, 2017
Add flow types to components; realted to #24
@wuweiweiwu
Copy link

@bvaughn Is this still in progress? I'd love to work on it

@bvaughn
Copy link
Contributor Author

bvaughn commented Jan 17, 2018

Please feel free to contribute anywhere you see missing types or types that could be improved, @wuweiweiwu. Probably worth checking through open pull requests first to make sure something hasn't already been done though! We usually let first-in win.

@wuweiweiwu
Copy link

@bvaughn Sounds good!

@kanitsharma
Copy link

Hey @bvaughn, I'd like to work on it too, is this still in progress?

@bvaughn
Copy link
Contributor Author

bvaughn commented Sep 5, 2018

I don't know. Looks like there's another open PR (#449) that got dropped because I just haven't had time to review this repo lately :( SOrry

@tricinel
Copy link
Contributor

tricinel commented Sep 5, 2018

I think it's a rather old issue and PR...Last year some time I believe...I haven't looked at it in a while either. It might be worth just doing a "close and forget" (on the PR) - I'd be ok with that of course. It's your call @bvaughn! I think we all appreciate the effort needed to review these 👍

@kanitsharma
Copy link

No problem :), just looking for an issue to get started here.

jhonmike pushed a commit to jhonmike/reactjs.org that referenced this issue Jul 1, 2020
* Add pt-BR translation to the invalid-aria-prop page

* Roll back WAI and ARIA translation. Fix minor typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants