Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grayscale and excessive margin top affects color-coded images and documentation #3008

Closed
kris10cabrera opened this issue Jun 1, 2020 · 5 comments

Comments

@kris10cabrera
Copy link

kris10cabrera commented Jun 1, 2020

Commit banner applies grayscale on documentation pages, as visible on Thinking in React, which makes the images unclear because the documentation references the image's colors.

Additionally the text is cut off on the bottom because of excessive margin top.

Screen Shot 2020-06-01 at 5 56 25 PM

Screen Shot 2020-06-01 at 5 56 16 PM

I was able to fix the problem locally by undoing the grayscale but I do not have write access to make a PR. (The edits in MarkdownHeader are not causing causing issues) thanks.

@kris10cabrera kris10cabrera changed the title Grayscale and banner messes up images and margin documentation Grayscale and excessive margin top messes up images and margin documentation Jun 2, 2020
@kris10cabrera kris10cabrera changed the title Grayscale and excessive margin top messes up images and margin documentation Grayscale and excessive margin top affects color-coded images and documentation Jun 2, 2020
@rimildeyjsr
Copy link

Came across the same issue while browsing through the Context API documentation, but this somehow seems to be localized to Chrome - this issue is not taking place in Safari or Firefox.

Screenshot from Safari:

Screenshot 2020-06-02 at 11 17 28 PM

Screenshot from Firefox:

Screenshot 2020-06-02 at 11 18 49 PM

@gaearon
Copy link
Member

gaearon commented Jun 3, 2020

Thanks for reporting.

I've fixed the blank text problem (seems to be caused by the filter affecting layout).

As for the color-coding, it is unfortunate but we're willing to temporarily leave this broken.

@gaearon gaearon closed this as completed Jun 3, 2020
@hoblin
Copy link

hoblin commented Jun 4, 2020

Is there any way to switch this grayscale filter off to see code highlight? At least for the ppl outside of the US?

@hoblin
Copy link

hoblin commented Jun 5, 2020

There is a women who was raped by two cops in Ukraine last week. Let’s switch colors to yellow-blue. Or you think that her life does not matter?

@hoblin
Copy link

hoblin commented Jun 5, 2020

Is it possible to opt-out of this? I need my pretty colors darn-it!

You can open devtools in the browser then find the CSS rule which begins with * { then add filter: none !important; to it and that will do the trick.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants