Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gracefully recover when ad block prevents Babel from loading #3

Closed
bvaughn opened this issue Oct 6, 2017 · 4 comments
Closed

Gracefully recover when ad block prevents Babel from loading #3

bvaughn opened this issue Oct 6, 2017 · 4 comments

Comments

@bvaughn
Copy link
Contributor

bvaughn commented Oct 6, 2017

I've seen reports that certain ad blockers (eg Fair AdBlocker 1.404) prevent Babel from loading which causes a script error and results in the following:
screen shot 2017-10-09 at 9 55 10 am

We could detect this case (eg no Babel) and show an error message about ad blockers specifically, letting users know to whitelist reactjs.org if they want the live code examples to work.

Note that this issue is related to issue #2 and may be impacted by its implementation.

@bvaughn
Copy link
Contributor Author

bvaughn commented Oct 9, 2017

Note that this issue was reported by another user but I am unable to reproduce it. Removing Babel entirely (so it isn't loaded) results in the following for me:
screen shot 2017-10-09 at 9 55 10 am

I think this is good enough. 😄

@bvaughn bvaughn closed this as completed Oct 9, 2017
@bvaughn
Copy link
Contributor Author

bvaughn commented Oct 9, 2017

Eh, maybe we could improve the error message slightly to mention ad blockers if we detect no Babel. I'll re-open and re-purpose for that.

@bvaughn bvaughn reopened this Oct 9, 2017
@renanpvaz
Copy link
Contributor

I can reproduce this, perhaps I can send a PR improving the message.

@bvaughn
Copy link
Contributor Author

bvaughn commented Oct 13, 2017

Great! This issue is all yours! 😄

I've added an "in-progress" label so that others will know not to start work on the issue. If you change your mind about the issue, no worries! Just let me know so that I can remove the label and free it up for someone else to claim.

Cheers!

bvaughn referenced this issue in bvaughn/reactjs.org Mar 7, 2018
Make the callback example more similar to the new API
alexkrolick referenced this issue in alexkrolick/reactjs.org Mar 23, 2018
jhonmike pushed a commit to jhonmike/reactjs.org that referenced this issue Jul 1, 2020
* Translation of the "Handling Events" page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants