Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Thinking In React example loads CodePen script multiple times #62

Closed
danielsbird opened this issue Oct 8, 2017 · 2 comments
Closed

Thinking In React example loads CodePen script multiple times #62

danielsbird opened this issue Oct 8, 2017 · 2 comments
Labels
difficulty: beginner good first issue in-progress type: website

Comments

@danielsbird
Copy link
Contributor

danielsbird commented Oct 8, 2017 •
edited

The Thinking in React doc has three embedded CodePens and each of them load the same script: one, two, three.

Loading CodePen's script once is enough to make all the pens on that page work.
@danielsbird danielsbird changed the title Thinking In React example loads Codepen script multiple times Thinking In React example loads CodePen script multiple times Oct 8, 2017
@bvaughn
Copy link
Contributor

bvaughn commented Oct 8, 2017

Thanks for pointing this out. Looks like a great first-task for someone!

@danielsbird danielsbird mentioned this issue Oct 8, 2017
Merged
@ishankbahl ishankbahl mentioned this issue Oct 8, 2017
Closed
@ishankbahl
Copy link
Contributor

Hey @bvaughn, made a pull request for this.

@bvaughn bvaughn closed this as completed Oct 8, 2017
jhonmike pushed a commit to jhonmike/reactjs.org that referenced this issue Jul 1, 2020
@eduardomoroni @fjoshuajr
Adiciona browser as glossario (reactjs#62)
32505d0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty: beginner good first issue in-progress type: website
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bvaughn @danielsbird @ishankbahl