Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CodePen examples to use latest React #69

Closed
bvaughn opened this issue Oct 8, 2017 · 8 comments
Closed

Update CodePen examples to use latest React #69

bvaughn opened this issue Oct 8, 2017 · 8 comments

Comments

@bvaughn
Copy link
Contributor

bvaughn commented Oct 8, 2017

IIRC currently they don’t. We should probably leave them using latest since if it breaks, we have to update them anyway.

Edit This issue is likely made unnecessary by the outcome #122

@bvaughn
Copy link
Contributor Author

bvaughn commented Oct 8, 2017

Auto-assigning to Dan since he owns most of the Codepens in question.

@swyxio
Copy link
Contributor

swyxio commented Oct 8, 2017

how can people who dont own these codepen's help? i am happy to reconstruct, just assign stuff to me

@bvaughn
Copy link
Contributor Author

bvaughn commented Oct 8, 2017

There are lots of issues tagged "good first issue". If you're interested in helping with the website, I recommend grabbing one of them! 😄 This particular issue is easier for Dan to handle which is why I've pre-assigned it to him.

@bvaughn bvaughn assigned bvaughn and unassigned gaearon Nov 17, 2017
@bvaughn
Copy link
Contributor Author

bvaughn commented Nov 17, 2017

This can be done as part of the Codepen-to-embedded migration now that we can link to embedded examples so I'll take this one on.

jhonmike pushed a commit to jhonmike/reactjs.org that referenced this issue Jul 1, 2020
BetterZxx pushed a commit to BetterZxx/react.dev that referenced this issue Mar 21, 2023
Might make people that are going through the docs confused.
@BartoszKlonowski
Copy link
Collaborator

Hello @bvaughn!
I believe this issue is already outdated and can be safely closed, as now the Sandpack is being successfully used and the versioning matter is solved.
Please correct me if I'm somehow wrong, otherwise we can close this.

@rickhanlonii
Copy link
Member

Yeah #122 closes this

@swyxio
Copy link
Contributor

swyxio commented Jan 12, 2024

hello friends happy 2024. time flies :)

@rickhanlonii
Copy link
Member

Hiiiii :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants