Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Static Type Checking" section to docs #76

Closed
bvaughn opened this issue Oct 8, 2017 · 6 comments
Closed

Add "Static Type Checking" section to docs #76

bvaughn opened this issue Oct 8, 2017 · 6 comments

Comments

@bvaughn
Copy link
Contributor

bvaughn commented Oct 8, 2017

This concern was originally raised by @barbu110 via facebook/react/issues/9684

Refer to the discussion on that thread for more backstory.

The outcome of that discussion is: Create a new guide called "Static Type Checking" that shows how to use React from Flow and TypeScript and describes main API definitions.

@ishankbahl
Copy link
Contributor

Hi @bvaughn , I would like to work on this one.

@bvaughn
Copy link
Contributor Author

bvaughn commented Oct 19, 2017

This issue is all yours! 😄

I've added an "in-progress" label so that others will know not to start work on the issue. If you change your mind about the issue, no worries! Just let me know so that I can remove the label and free it up for someone else to claim.

Cheers!

@ishankbahl
Copy link
Contributor

@bvaughn
Just saw that entire API reference has been added to the flow website
( https://flow.org/en/docs/react/types/ ). Is this guide necessary now or not?

@bvaughn
Copy link
Contributor Author

bvaughn commented Oct 19, 2017

This issue originally covered TypeScript as well as Flow.

Looks like TypeScript also has a brief introduction to TypeScript + React on their site.

Maybe it's okay to have a minimal section for Flow and TypeScript integration and then link to the official docs pages for more details?

@ishankbahl
Copy link
Contributor

@bvaughn made a PR for this two days back.

@bvaughn
Copy link
Contributor Author

bvaughn commented Nov 7, 2017

Closed by #189

Thanks Ishank!

@bvaughn bvaughn closed this as completed Nov 7, 2017
jhonmike pushed a commit to jhonmike/reactjs.org that referenced this issue Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants