Update web-components.md #1514
Update web-components.md #1514
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
Deploy preview for reactjs ready! Built with commit 8ca53d6 |
There was a problem hiding this comment.
@arjunyel I am happy that you took the time to contribute and help this document get better, however for future reference when you open a PR like this would be nice to explain with few words your motivation of doing something so that it is for everyone clear.
Usually there are issues on a repository and given these issues people open PRs. Thats not always the case but one needs to be very experienced to break this rule. Another way to go would be for one to create an issue by herself and a complementary PR to close this issue. This way you keep people informed with your motives ;)
Hope this helps!! Thanks for taking the time and effort to contribute! Keep it up 👍
|
I think we kept that line explicitly to be clear about the level of support. We'll revisit it soon in some fashion. Thanks for your PR! |
Removed unnecessary line