Fix sentence negation in Step 2 #2238
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Deploy preview for reactjs ready! Built with commit f8ec8a3 |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
No, the original version is correct. It's saying "(Even if) you're familiar with state, don't use it for this project". I agree it might cause some confusion. What do you think we should reword it to? Should we just delete that clause? |
|
If that's the case, I think we can delete the sentence "If you’re familiar with the concept of state, don’t use state at all to build this static version". Also, the last sentence "Since this is a static version of the app, you don’t need it." clarifies it. If we want to keep it we can change it to "Don’t use state to build this static version". |
|
@tesseralis Please review the new commit. If that's better can you please close this? Thanks. |
|
It's trying to say "don't use state to build this part (and if this is the first time you've heard of 'state' don't worry about it, we'll get to it"). Can you come up with something that preserves that meaning? |
Updated the description based on the comment below. _Originally posted by @alexkrolick in reactjs#2238 (comment)
|
Updated the description. Please review |
No description provided.