Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a little feedback form to the bottom of each page using GA #3170

Merged
merged 3 commits into from Aug 4, 2020

Conversation

rachelnabors
Copy link
Contributor

How it looks:

Screenshot 2020-08-04 at 16 02 05

And how it looks after you click:

Screenshot 2020-08-04 at 16 02 14

Copy link
Contributor

@bvaughn bvaughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to fix some lint issues that are currently causing CI to fail. Otherwise looks good.

src/components/MarkdownPage/MarkdownPage.js Outdated Show resolved Hide resolved
action: 'feedback',
label: window.location.pathname,
value: 1,
});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know much about how our GA stuff works. I assumed these buttons are wired up correctly and have been confirmed to work? 😄

@rachelnabors rachelnabors merged commit 64c51d4 into reactjs:master Aug 4, 2020
@rachelnabors rachelnabors deleted the docs-feedback-form branch August 4, 2020 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants