Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(cn): translate content/blog/2022-06-15-react-labs-what-we-have-been-working-on-june-2022.md into Chinese #870

Merged
merged 5 commits into from Jul 21, 2022
Merged

docs(cn): translate content/blog/2022-06-15-react-labs-what-we-have-been-working-on-june-2022.md into Chinese #870

merged 5 commits into from Jul 21, 2022

Conversation

blackstoneblackstone
Copy link
Contributor

I have translated the latest blog of React into Chinese, please review it and hope it can be adopted.

@blackstoneblackstone blackstoneblackstone changed the title Feature/blackstone trans Translate the latest blog into English. Jul 15, 2022
@blackstoneblackstone blackstoneblackstone marked this pull request as draft July 15, 2022 09:07
@blackstoneblackstone blackstoneblackstone marked this pull request as ready for review July 15, 2022 09:08
@blackstoneblackstone
Copy link
Contributor Author

@Huxpro 求 review ，感谢！

@Huxpro
Copy link
Member

Huxpro commented Jul 18, 2022

@Huxpro 求 review ，感谢！

你可以直接在 request review 里填我吗这样我好记得？还是说我现在还不在这个 org/repo 里所以没法儿

@awxiaoxian2020
Copy link
Collaborator

@Huxpro 求 review ，感谢！

你可以直接在 request review 里填我吗这样我好记得？还是说我现在还不在这个 org/repo 里所以没法儿

第一次的贡献者似乎没有指定 reviewer 的权限，只有组织成员才有这个权限吧。

@blackstoneblackstone
Copy link
Contributor Author

@Huxpro 我确实没有这个权限，没有“设置”的按钮。
image

@github-actions
Copy link

github-actions bot commented Jul 20, 2022 •
edited

Size Changes

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

This PR introduced no changes to the javascript bundle 🙌

Huxpro
Huxpro previously approved these changes Jul 21, 2022
View reviewed changes
Copy link
Member

@Huxpro Huxpro left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感谢翻译！整体不错得，对一些意思偏差大一点得做了一些修改

content/blog/2022-06-15-react-labs-what-we-have-been-working-on-june-2022.md Outdated Show resolved Hide resolved
content/blog/2022-06-15-react-labs-what-we-have-been-working-on-june-2022.md Outdated Show resolved Hide resolved
content/blog/2022-06-15-react-labs-what-we-have-been-working-on-june-2022.md Outdated Show resolved Hide resolved
content/blog/2022-06-15-react-labs-what-we-have-been-working-on-june-2022.md Outdated Show resolved Hide resolved
content/blog/2022-06-15-react-labs-what-we-have-been-working-on-june-2022.md Outdated Show resolved Hide resolved
content/blog/2022-06-15-react-labs-what-we-have-been-working-on-june-2022.md Outdated Show resolved Hide resolved
content/blog/2022-06-15-react-labs-what-we-have-been-working-on-june-2022.md Outdated Show resolved Hide resolved
content/blog/2022-06-15-react-labs-what-we-have-been-working-on-june-2022.md Outdated Show resolved Hide resolved
content/blog/2022-06-15-react-labs-what-we-have-been-working-on-june-2022.md Outdated Show resolved Hide resolved
content/blog/2022-06-15-react-labs-what-we-have-been-working-on-june-2022.md Outdated Show resolved Hide resolved
@Huxpro
Copy link
Member

Huxpro commented Jul 21, 2022

哦话说 PR 标题是不是可以改成：翻译「React Labs: What We've Been Working On – June 2022」？

@KnowsCount @Huxpro
fix: polish inadequate translation
b67eceb 
Co-authored-by: Xuan Huang (黄玄) <huxpro@gmail.com>
@KnowsCount
Copy link
Collaborator

哦话说 PR 标题是不是可以改成：翻译「React Labs: What We've Been Working On – June 2022」？

@blackstoneblackstone 应修改为 docs(cn): translate 完整的文件路径 into Chinese

@KnowsCount
fix: change translation for 'asset' to '静态资源' in lieu of '资产'
92f9b41 
as @Huxpro did remark, the initial translation is not the most conventional nor the best-fitting one.
@blackstoneblackstone blackstoneblackstone changed the title Translate the latest blog into English. 翻译「React Labs: What We've Been Working On – June 2022」 Jul 21, 2022
@blackstoneblackstone blackstoneblackstone changed the title 翻译「React Labs: What We've Been Working On – June 2022」 docs(cn): translate content/blog/2022-06-15-react-labs-what-we-have-been-working-on-june-2022.md into Chinese Jul 21, 2022
@blackstoneblackstone
Copy link
Contributor Author

哦话说 PR 标题是不是可以改成：翻译「React Labs: What We've Been Working On – June 2022」？

@blackstoneblackstone 应修改为 docs(cn): translate 完整的文件路径 into Chinese

done

@QC-L QC-L merged commit 2d26cc7 into reactjs:main Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KnowsCount KnowsCount KnowsCount approved these changes

@Huxpro Huxpro Huxpro left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@blackstoneblackstone @Huxpro @awxiaoxian2020 @KnowsCount @QC-L