[Question] Is this the right way to customize blockhound-junit-platform?

[dsibilio]

Not really an issue, but I couldn't find a gitter channel for BlockHound where I would've asked this question otherwise :)

I'm playing around with BlockHound JUnit Platform for a little demo based on Project Reactor (https://github.com/dsibilio/blockhound-demo).

While fiddling with it, I noticed that the ch.qos.logback.classic.Logger#buildLoggingEventAndAppend got flagged downstack due to some blocking IO.

Of course I wanted to allow this method but I couldn't find a way to customize BlockHound before initialization since it gets done for me by the BlockHoundTestExecutionListener.java, so I had to:

• replace blockhound-junit-platform with blockhound dependency;
• write my own TestExecutionListener with the forementioned method set as allowed;
• add the META-INF/services/[...]TestExecutionListener file that lists my implementation for SPI dependency injection.

So, as per title, is this the right way to allow/disallow custom methods when wanting to use blockhound-junit-platform? Or is there something obvious that I might've missed?

Thanks in advance :)

[bsideup]

Hi! There is much easier way: SPI! :)

https://github.com/reactor/BlockHound/blob/master/docs/custom_integrations.md

You just need to create an integration and META-INF/services/... file

Example:
https://github.com/reactor/reactor-netty/blob/enable_blockhound/src/test/java/reactor/netty/NettyTestBlockHoundIntegration.java

[dsibilio]

Thanks, didn't notice the empty varargs install method loaded all the integrations.
Integrated the change in my demo and everything still works, much better.

Thank you! :)

[bsideup]

Good!

I'm going to close the issue (the SPI mechanism is mentioned in the docs too)

[bsideup]

FYI I created a Gitter room :) https://gitter.im/reactor/BlockHound