Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manually stopped partitions should not be resumed by reactor-kafka #48

Closed
bsideup opened this issue Jul 21, 2018 · 2 comments
Closed

Manually stopped partitions should not be resumed by reactor-kafka #48

bsideup opened this issue Jul 21, 2018 · 2 comments
Assignees
Labels
type/enhancement A general enhancement

Comments

@bsideup
Copy link
Contributor

bsideup commented Jul 21, 2018

Hi!

Observed behaviour:
If user manually stops some of the assigned partitions, PollEvent will resume it on a next flow control action:

if (requestsPending.get() > 0 && !awaitingTransaction.get()) {
if (partitionsPaused.getAndSet(false))
consumer.resume(consumer.assignment());
} else {
if (!partitionsPaused.getAndSet(true))
consumer.pause(consumer.assignment());
}

Expected behaviour:
Manually controlled partitions should be respected and not affected by PollEvent's logic.

Version:
Both 1.0.0.RELEASE and latest master

@OlegDokuka OlegDokuka added this to the 1.0.1.RELEASE milestone Jul 21, 2018
@OlegDokuka OlegDokuka self-assigned this Jul 21, 2018
@OlegDokuka OlegDokuka added the type/enhancement A general enhancement label Jul 21, 2018
@OlegDokuka OlegDokuka modified the milestones: 1.1.1.RELEASE, 3.2.x Oct 11, 2018
@Delorien84
Copy link

I am voting for that issue. I want to just fill same issue. Currently I implemented ugly workaround, that check incoming records and re-pause and seek the partition when additional messages comes, when it should not.

@bsideup bsideup removed this from the 3.2.x.RELEASE milestone Jun 10, 2019
@garyrussell
Copy link
Contributor

Fixed by #199 last year.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

4 participants