Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ByteBuf is too unqualified for WebSocket messages #14

Closed
rstoyanchev opened this issue Dec 6, 2016 · 1 comment
Closed

ByteBuf is too unqualified for WebSocket messages #14

rstoyanchev opened this issue Dec 6, 2016 · 1 comment
Milestone

Comments

@rstoyanchev
Copy link
Contributor

For WebSocket the NettyInbound.receive() which provides ByteBuf's is too unqualified to be useful because there is no way of knowing the boundaries of a complete WebSocket message nor whether it is binary, text, or pong. It's possible to use NettyInbound.receiveObject().cast(WebSocketFrame.class) but it would be nicer if a handler is given something a little less generic and more tailored to a WebSocket interaction -- e.g. a receive method that provides WebSocketFrame's.

A similar improvement on the outbound side would remove the need to specify text vs binary when calling one of the HttpOutbound#upgradeToWebSocketXxx methods since the input would already be WebSocketFrame's.

@smaldini smaldini added this to the 0.6.0.RELEASE milestone Dec 23, 2016
@smaldini
Copy link
Contributor

Fixed with WebsocketInbound#receiveFrames()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants