Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client should use GET not CONNECT with proxy when target URI is HTTP #2349

Closed
micw opened this issue Jul 3, 2022 · 1 comment
Closed

Client should use GET not CONNECT with proxy when target URI is HTTP #2349

micw opened this issue Jul 3, 2022 · 1 comment
Labels
for/netty This belongs to the Netty project

Comments

@micw
Copy link

micw commented Jul 3, 2022

Expected Behavior

When accessing an URI via proxy, the client should use "GET" for HTTP-Targets and CONNECT for HTTPS-Targets.

Actual Behavior

The Client always uses CONNECT. This is technical valid but breaks things like proxy-side request filtering for Non-HTTP requests.

Steps to Reproduce

Create a client with http proxy set to localhost:someport. Run netcat (nc -l -p someport). Query a http url through that client. Check what request is issued.

Your Environment

  • Reactor version(s) used: reactor-core-3.4.18, reactor-netty-core-1.0.19
@micw micw added status/need-triage A new issue that still need to be evaluated as a whole type/bug A general bug labels Jul 3, 2022
@violetagg violetagg added for/netty This belongs to the Netty project and removed type/bug A general bug status/need-triage A new issue that still need to be evaluated as a whole labels Jul 3, 2022
@violetagg
Copy link
Member

@micw Follow this issue netty/netty#10475 in Netty project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
for/netty This belongs to the Netty project
Projects
None yet
Development

No branches or pull requests

2 participants