Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse request body #105

Closed
clue opened this issue Feb 10, 2017 · 4 comments
Closed

Parse request body #105

clue opened this issue Feb 10, 2017 · 4 comments
Assignees
Milestone

Comments

@clue
Copy link
Member

clue commented Feb 10, 2017

We should provide an easier way to access the parsed request body, i.e. $_POST values from HTML forms, file uploads etc.

This depends on detecting actual message lengths first, see #104.

I'm filing this mostly for the reference, there's been some discussion to wait for PSR-7 message support (#28) first.

@clue clue added this to the v0.5.0 milestone Feb 10, 2017
@clue
Copy link
Member Author

clue commented Feb 10, 2017

For the reference: Parts of this had been implemented on the master branch but had to be reverted due to licensing and blocking issues, see #59 for more details.

Some projects have started to build on top of this, so we're currently providing a dev branch for this: https://github.com/reactphp/http/tree/streaming-multipart. See also #41 for more details. Note that this is development preview only and we can only provide limited support for this.

In other words: If you run into issues with this branch, please refrain from opening new issues and comment on the respective PRs instead.

It's very likely the future version will look somewhat different than this development preview, so please think twice before relying on this 👍

@clue
Copy link
Member Author

clue commented Feb 10, 2017

It's very likely the future version will look somewhat different than this development preview […]

Rest assured, we're working on hard on providing a stable base for this soon. Bear with us and we'll keep this ticket updated 👍

@andig
Copy link
Contributor

andig commented Feb 10, 2017

+1 for keeping the ability to access plain body. Otherwise it becomes horribly cumbersome to interface e.g. with symfony/httpkernel (observed as problem in php-pm/php-pm#203)

@WyriHaximus
Copy link
Member

@andig without any doubt we will allow users to have access to the raw body

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants