Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate reasonable default limits and timeout values #194

Closed
clue opened this issue May 28, 2017 · 1 comment
Closed

Evaluate reasonable default limits and timeout values #194

clue opened this issue May 28, 2017 · 1 comment

Comments

@clue
Copy link
Member

clue commented May 28, 2017

Currently, this project does not implement any timeouts whatsoever.

Depending on a number of factors, a malicious client may be able to consume all open sockets and/or available bandwidth, so that no legitimate client may be able to use this server anymore.

As such, it's probably safer to deploy this behind a reverse proxy such as nginx or haproxy if you want to open this to a broader public (aka the internet).

This ticket aims to serve as a base to discuss, evaluate and subsequently implement reasonable limits so that this is no longer needed.

@clue
Copy link
Member Author

clue commented Mar 20, 2018

I'm closing this for now as it hasn't received any input in a while and I have no plans to change this myself anytime soon and I'm not sure there's an issue in the first place. Please come back if you feel this is still an issue and we can reopen this 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant