Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HttpBodyStream not fired close immediate when browser is close #210

Closed
bungkusansayuran opened this issue Jul 25, 2017 · 1 comment · Fixed by #315
Closed

HttpBodyStream not fired close immediate when browser is close #210

bungkusansayuran opened this issue Jul 25, 2017 · 1 comment · Fixed by #315

Comments

@bungkusansayuran
Copy link

HttpBodyStream fired close when after browser/client close and emit 1 or more data, not fired after browser/client close.

@clue
Copy link
Member

clue commented Aug 14, 2017

Thanks for reporting, this actually raises an interesting issue!

Can you give some details on where you spotted this and if this is an issue for your use case?

Currently, we pause() the input stream once we no longer accept any data from the client (i.e. after the request has been processed). However, a stream that is in a paused state does not report a remote close event anymore. This means that a closed connection will only be detected once we try to send the response over the closed connection.

This refs #39 because persistent connections allow us to read the next request from the connection, thus likely keeping the connection in a resumed (un-paused) state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants