Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename to promise-timer #11

Closed
clue opened this issue Jul 2, 2015 · 1 comment
Closed

Rename to promise-timer #11

clue opened this issue Jul 2, 2015 · 1 comment

Comments

@clue
Copy link
Member

clue commented Jul 2, 2015

After talking to @jsor about #2 we agree that the packge name should be changed.

The package name should be "promise-timer" instead of "promise-timeout", as only a single function actually deals with timing out promises.

Accordingly, the namespace should be changed from "Promise\Timeout" to "Promise\Timer" (see also #10).

Timeout\await() => Timeout\timeout() => Timer\timeout() (see also #10)
Timeout\resolve() => Timer\resolve()
Timeout\reject() => Timer\reject()
@jsor
Copy link
Member

jsor commented Jul 3, 2015

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants