Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw exceptions if no error listeners are present #42

Closed
igorw opened this issue Jun 28, 2012 · 2 comments
Closed

Throw exceptions if no error listeners are present #42

igorw opened this issue Jun 28, 2012 · 2 comments

Comments

@igorw
Copy link
Contributor

igorw commented Jun 28, 2012

No description provided.

@JCook21
Copy link

JCook21 commented Mar 1, 2013

I've added a commit for this at https://github.com/JCook21/react/commit/a4d0fab19cd11aa95e8a82d37dc61e62b19c4b2f. The only way I could see to have an error triggered when the loop is run if there are no error listeners is to have the loop extend Evenement\EventEmitter. This also means that other components can emit error events through the loop, allowing that event to aggregate all errors in it. I've added code wherever I could to have other components also emit an error event on the loop wherever possible while still emitting their own, existing errors.

I'd be curious to know what you think about this change. I think there are advantages and drawbacks to this but at the moment I can't think of a better way to achieve the result.

@clue
Copy link
Member

clue commented Nov 7, 2017

I'm closing this for now as it hasn't received any input in a long while and things have changed considerably since this ticket has been opened and it's unclear how much value this would provide nowadays. Please come back with more details if this is still an issue and we can reopen this 👍

@clue clue closed this as completed Nov 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants