Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twig Extension undefined index notice #40

Closed
mattsches opened this issue Aug 16, 2018 · 3 comments
Closed

Twig Extension undefined index notice #40

mattsches opened this issue Aug 16, 2018 · 3 comments

Comments

@mattsches
Copy link

The ReactPHP website displays a PHP notice with its stack trace in the activity box on the lower right (see attached screenshot).

This happens because the $participation array does not contain the index all. Might have sth. to do with connectivity issues to Travis, or maybe they changed something on their side?

auswahl_029

@jsor
Copy link
Member

jsor commented Aug 16, 2018

Thanks for reporting, that alread happened a few times. The reason is probably a failed call of the github API.

We should probably fail the build in this case.

@WyriHaximus
Copy link
Member

We should probably fail the build in this case.

👍 on failing the build in that case.

@jsor
Copy link
Member

jsor commented Aug 16, 2018

See #41

@jsor jsor closed this as completed in #41 Aug 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants